Improved perf for followers and following list

Ref: https://linear.app/ghost/issue/AP-1042
Ref: https://linear.app/ghost/issue/AP-1041

- Using a single endpoint for both local and remote follow lookups - GET /.ghost/activitypub/account/following/?handle=@username@domain'.
- If it's a ghost account(internal account), this endpoint will return the data from our db.
- If the account is an external account, it will fall back to calling the outbox and retrieving data from there.

Author: vershwal

Diff for: src/app.ts

@@ -106,8 +106,6 @@ import {
     createGetFeedHandler,
     createGetNotificationsHandler,
     createGetPostHandler,
-    createGetProfileFollowersHandler,
-    createGetProfileFollowingHandler,
     createGetThreadHandler,
     createPostPublishedWebhookHandler,
     createSearchHandler,
@@ -954,16 +952,6 @@ app.get(
     requireRole(GhostRole.Owner, GhostRole.Administrator),
     spanWrapper(createSearchHandler(accountService)),
 );
-app.get(
-    '/.ghost/activitypub/profile/:handle/followers',
-    requireRole(GhostRole.Owner, GhostRole.Administrator),
-    spanWrapper(createGetProfileFollowersHandler(accountService)),
-);
-app.get(
-    '/.ghost/activitypub/profile/:handle/following',
-    requireRole(GhostRole.Owner, GhostRole.Administrator),
-    spanWrapper(createGetProfileFollowingHandler(accountService)),
-);
 app.get(
     '/.ghost/activitypub/thread/:post_ap_id',
     spanWrapper(createGetThreadHandler(postRepository, accountService)),
@@ -991,7 +979,11 @@ app.get(
     '/.ghost/activitypub/account/:handle/follows/:type',
     requireRole(GhostRole.Owner, GhostRole.Administrator),
     spanWrapper(
-        createGetAccountFollowsHandler(accountRepository, accountFollowsView),
+        createGetAccountFollowsHandler(
+            accountRepository,
+            accountFollowsView,
+            fedifyContextFactory,
+        ),
     ),
 );
 app.get(

Diff for: src/http/api/account.ts

@@ -2,6 +2,7 @@ import type { Federation } from '@fedify/fedify';
 import type { Account } from 'account/account.entity';
 import type { KnexAccountRepository } from 'account/account.repository.knex';
 import type { AccountService } from 'account/account.service';
+import type { FedifyContextFactory } from 'activitypub/fedify-context.factory';
 import type { AppContext, ContextData } from 'app';
 import { isHandle } from 'helpers/activitypub/actor';
 import { lookupAPIdByHandle } from 'lookup-helpers';
@@ -11,7 +12,10 @@ import {
     getAccountDTOFromAccount,
 } from './helpers/account';
 import type { AccountDTO } from './types';
-import type { AccountFollowsView } from './views/account.follows.view';
+import type {
+    AccountFollows,
+    AccountFollowsView,
+} from './views/account.follows.view';
 
 /**
  * Default number of posts to return in a profile
@@ -112,6 +116,7 @@ export function createGetAccountHandler(
 export function createGetAccountFollowsHandler(
     accountRepository: KnexAccountRepository,
     accountFollowsView: AccountFollowsView,
+    fedifyContextFactory: FedifyContextFactory,
 ) {
     /**
      * Handle a request for a list of account follows
@@ -121,30 +126,51 @@ export function createGetAccountFollowsHandler(
     return async function handleGetAccountFollows(ctx: AppContext) {
         const site = ctx.get('site');
 
-        // Validate input
         const handle = ctx.req.param('handle') || '';
-
         if (handle === '') {
             return new Response(null, { status: 400 });
         }
 
         const type = ctx.req.param('type');
-
         if (!['following', 'followers'].includes(type)) {
             return new Response(null, { status: 400 });
         }
 
         const siteDefaultAccount = await accountRepository.getBySite(site);
 
-        // Get follows accounts and paginate
-        const queryNext = ctx.req.query('next') || '0';
-        const offset = Number.parseInt(queryNext);
+        const queryNext = ctx.req.query('next');
+        const next = queryNext ? decodeURIComponent(queryNext) : null;
 
-        const accountFollows = await accountFollowsView.getFollows(
-            type,
-            siteDefaultAccount,
-            offset,
-        );
+        let accountFollows: AccountFollows;
+
+        if (handle === 'me') {
+            accountFollows = await accountFollowsView.getFollowsByAccount(
+                siteDefaultAccount,
+                type,
+                Number.parseInt(next || '0'),
+                siteDefaultAccount,
+            );
+        } else {
+            const ctx = fedifyContextFactory.getFedifyContext();
+            const apId = await lookupAPIdByHandle(ctx, handle);
+
+            if (!apId) {
+                return new Response(null, { status: 400 });
+            }
+
+            const account = await accountRepository.getByApId(new URL(apId));
+            if (!account) {
+                return new Response(null, { status: 400 });
+            }
+
+            accountFollows = await accountFollowsView.getFollowsByHandle(
+                handle,
+                account,
+                type,
+                next,
+                siteDefaultAccount,
+            );
+        }
 
         // Return response
         return new Response(

Diff for: src/http/api/index.ts

@@ -3,7 +3,6 @@ export * from './feed';
 export * from './notification';
 export * from './note';
 export * from './post';
-export * from './profile';
 export * from './search';
 export * from './thread';
 export * from './webhook';