[solved] - 1.1.2 is breaking my app with TS errors...

[smolinari]

Hey @TriPSs,

I upgraded my project to 1.1.2 expecting everything to just work, but I've hit this TS issue during the build and not sure why. Hoping you might have an idea. It doesn't seem directly related to anything I changed. At least I can't tell at first glance. That being said, this isn't an issue with 1.1.1, so it probably does have something to do with what I changed. I just have no idea what that might be.

../../common/temp/node_modules/.pnpm/@[email protected]_rcpe4wdvuvh657jmhfzlqyj5iq/node_modules/@ptc-org/nestjs-query-core/src/helpers/filter.helpers.d.ts(13,670): error TS2677: A type predicate's type must be assignable to its parameter's type.
  Type 'DTO[K] extends infer T ? T extends DTO[K] ? T extends string | String ? StringFieldComparisons : T extends boolean | Boolean ? BooleanFieldComparisons : T extends number | ... 4 more ... | (string | ... 5 more ... | Date)[] ? CommonFieldComparisonType<...> : T extends (infer U)[] ? CommonFieldComparisonType<...> | F...' is not assignable to type 'Filter<DTO[K]> | (DTO[K] extends infer T ? T extends DTO[K] ? T extends string | String ? StringFieldComparisons : T extends boolean | Boolean ? BooleanFieldComparisons : T extends number | ... 4 more ... | (string | ... 5 more ... | Date)[] ? CommonFieldComparisonType<...> : T extends (infer U)[] ? CommonFieldCompa...'.
    Type 'unknown extends DTO[K] ? Filter<DTO[K]> | CommonFieldComparisonType<DTO[K]> : never' is not assignable to type 'Filter<DTO[K]> | (DTO[K] extends infer T ? T extends DTO[K] ? T extends string | String ? StringFieldComparisons : T extends boolean | Boolean ? BooleanFieldComparisons : T extends number | ... 4 more ... | (string | ... 5 more ... | Date)[] ? CommonFieldComparisonType<...> : T extends (infer U)[] ? CommonFieldCompa...'.
      Type 'Filter<DTO[K]> | CommonFieldComparisonType<DTO[K]>' is not assignable to type 'Filter<DTO[K]> | (DTO[K] extends infer T ? T extends DTO[K] ? T extends string | String ? StringFieldComparisons : T extends boolean | Boolean ? BooleanFieldComparisons : T extends number | ... 4 more ... | (string | ... 5 more ... | Date)[] ? CommonFieldComparisonType<...> : T extends (infer U)[] ? CommonFieldCompa...'.
        Type 'CommonFieldComparisonType<DTO[K]>' is not assignable to type 'Filter<DTO[K]> | (DTO[K] extends infer T ? T extends DTO[K] ? T extends string | String ? StringFieldComparisons : T extends boolean | Boolean ? BooleanFieldComparisons : T extends number | ... 4 more ... | (string | ... 5 more ... | Date)[] ? CommonFieldComparisonType<...> : T extends (infer U)[] ? CommonFieldCompa...'.
  ...4 lines omitted...
                  Type 'Filter<DTO[K]> | CommonFieldComparisonType<DTO[K]>' is not assignable to type 'Filter<DTO[K]>'.
                    Type 'CommonFieldComparisonType<DTO[K]>' is not assignable to type 'Filter<DTO[K]>'.
                      Type 'CommonFieldComparisonType<DTO[K]>' is not assignable to type 'FilterComparisons<DTO[K]>'.
                        Type 'unknown extends DTO[K] ? Filter<DTO[K]> | CommonFieldComparisonType<DTO[K]> : never' is not assignable to type 'FilterGrouping<DTO[K]>'.
                          Type 'Filter<DTO[K]> | CommonFieldComparisonType<DTO[K]>' is not assignable to type 'FilterGrouping<DTO[K]>'.
                            Type 'CommonFieldComparisonType<DTO[K]>' has no properties in common with type 'FilterGrouping<DTO[K]>'.
                              Type 'DTO[K] extends infer T ? T extends DTO[K] ? T extends string | String ? StringFieldComparisons : T extends boolean | Boolean ? BooleanFieldComparisons : T extends number | ... 4 more ... | (string | ... 5 more ... | Date)[] ? CommonFieldComparisonType<...> : T extends (infer U)[] ? CommonFieldComparisonType<...> | F...' is not assignable to type 'FilterGrouping<DTO[K]>'.
                                Type 'unknown extends DTO[K] ? Filter<DTO[K]> | CommonFieldComparisonType<DTO[K]> : never' is not assignable to type 'FilterGrouping<DTO[K]>'.
                                  Type 'Filter<DTO[K]> | CommonFieldComparisonType<DTO[K]>' is not assignable to type 'FilterGrouping<DTO[K]>'.
                                    Type 'CommonFieldComparisonType<DTO[K]>' has no properties in common with type 'FilterGrouping<DTO[K]>'.


Operations failed.

Scott

[TriPSs]

You did it have this issue when compiling / running the version locally?

[smolinari]

No, and interestingly enough, if I link it into my project locally, I get a totally different issue... Hmm.... 🤔

Scott

[smolinari]

@TriPSs - Just a wild guess, but what version of Typescript was used to compile the version that is published to npm?

Scott

[TriPSs]

Would expect that to be the version that is in the lock file.

[smolinari]

Oh. yeah. Hmm... was thinking (stupidly) that maybe the global tsc is being used. Have you upgraded your app to the newest version yet and is it working ok?

Scott

[TriPSs]

I have not, will try this today!

[smolinari]

I've removed the setting declaration: true in my tsconfig and 1.1.2 is now working for me. I'm also not 100% certain that was the fix, but it is all good now.

Scott

[smolinari]

I can now confirm 100% that the declarations setting caused the issue.

Scott