Skip to content

Commit f6d488a

Browse files
committed
test: add type annotations for web.Registry instances
1 parent 3a54f65 commit f6d488a

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

tests/core_tests/util_tests/test_web.py

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def test_paste_error(mock_requests):
4848

4949

5050
def test_registry_items():
51-
registry = web.Registry()
51+
registry = web.Registry[object]()
5252
obj = object()
5353
registry.register("test", obj)
5454
item = registry.get_item("test")
@@ -57,9 +57,10 @@ def test_registry_items():
5757

5858

5959
def test_registry_item_working(freeze_time):
60-
registry = web.Registry()
60+
registry = web.Registry[object]()
6161
registry.register("test", object())
6262
item = registry.get_item("test")
63+
assert item is not None
6364
assert item.should_use
6465

6566
item.failed()
@@ -271,18 +272,20 @@ def test_expand(mock_requests):
271272
def test_register_duplicate_paste():
272273
obj = object()
273274
obj1 = object()
275+
registry = web.Registry[object]()
274276

275-
web.pastebins.register("test", obj)
277+
registry.register("test", obj)
276278
with pytest.raises(ValueError):
277-
web.pastebins.register("test", obj1)
279+
registry.register("test", obj1)
278280

279-
web.pastebins.remove("test")
281+
registry.remove("test")
280282

281283

282284
def test_remove_paste():
283285
obj = object()
286+
registry = web.Registry[object]()
284287

285-
web.pastebins.register("test", obj)
286-
assert web.pastebins.get("test") is obj
287-
web.pastebins.remove("test")
288-
assert web.pastebins.get("test") is None
288+
registry.register("test", obj)
289+
assert registry.get("test") is obj
290+
registry.remove("test")
291+
assert registry.get("test") is None

tests/plugin_tests/test_admin_bot.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,7 @@ def f(self, attr):
8585
event.__getitem__ = f
8686
event.event = event
8787

88-
res = await func_utils.call_with_args(admin_bot.me, event)
89-
assert res is None
88+
await func_utils.call_with_args(admin_bot.me, event)
9089
assert event.mock_calls == [
9190
call.admin_log('bar used ME to make me ACT "do thing" in #foo.'),
9291
call.conn.ctcp("#foo", "ACTION", "do thing"),

0 commit comments

Comments
 (0)