Fix property audits_with_args in model definition.py #3904
Merged
+45
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey @blecourt-private, thank you for the PR! Can you please add some tests and explain what motivated this PR? |
I have just added this issue (more or less copy-paste from this message I posted in the Slack channel yesterday). @treysp promised to look into it, but in the mean time I thought I would try to see if I could contribute. Will try to add some tests now! |
|
@georgesittas @treysp |
treysp
force-pushed
the
fix-audits-with-args
branch
from
5cc1754 to
1edd570
Compare
treysp
approved these changes
Feb 26, 2025
treysp
force-pushed
the
fix-audits-with-args
branch
from
1edd570 to
53ca232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.