Add optional pyodbc driver for mssql and azuresql #3882
+34
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erindru
reviewed
Feb 23, 2025
|
|
||
| type_: t.Literal["mssql"] = Field(alias="type", default="mssql") | ||
|
|
||
| @property | ||
| def _connection_kwargs_keys(self) -> t.Set[str]: | ||
| return { | ||
| "host", | ||
| "authentication", |
There was a problem hiding this comment.
I know this PR is still in draft, but instead of defining authentication it might be worth defining a dict of arbitrary odbc_properties instead, since there are a bunch that can be specified.
That way it's clear that these only work in ODBC mode, and theyre passed verbatim to the ODBC driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the possibility to use pyodbc as the driver for MSSQL (and Azure SQL).