Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate suggestions when input has initial upper case, suggestion can be both a name and a regular noun #15

Open
snomos opened this issue Dec 8, 2015 · 0 comments

Comments

@snomos
Copy link

snomos commented Dec 8, 2015

I have run a comparison of the voikko-based speller with the hfst-ospell-office speller. The result is visible here (first 7 diffs, available for a month):

https://www.diffnow.com/?report=5m6dx

As can be seen in the seventh diff, the same suggestion is given twice. This is caused by two suggestions that are underlyingly different only in their initial case (but thus still different), but which are made identical because the input has initial uppercase, and so both suggestions will have initial upper case, which makes them identical.

There needs to be a check for uniqueness within the final suggestion list, and if two identical suggestions are found, only the first/best one is returned.

@snomos snomos changed the title Duplicate suggestions with initial upper case when both a name and a regular noun Duplicate suggestions when input has initial upper case, suggestion can be both a name and a regular noun Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant