Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some very simple documentation requests #219

Open
markyoder opened this issue Mar 21, 2023 · 3 comments
Open

Some very simple documentation requests #219

markyoder opened this issue Mar 21, 2023 · 3 comments

Comments

@markyoder
Copy link

Hi - Can I request/recommend some very simple modifications to the installation documentation?

Namely, what compilers should be what? For example, I understand that the environment variable CC is interpreted by cmake as the c-compiler, but it is not clear to me whether that should be set to the gnu compiler, or the nvhpc compiler. Should this look something like,
CC=gcc or CC=nvc

Also, I understand that there are many c++ standards, but how specifically should -DSTD= be defined? -DSTD=11, -DSTD=c++11, ???

Turns out I can find this by sifting through the "successful builds," but a short, basic explanation in the "install" section of how to make certain specifications would be extremely helpful.

Thanks in advance for any clarity you can provide!

@zhi-wang
Copy link
Member

No problem. I'll further clarify the documentation later.

@markyoder
Copy link
Author

markyoder commented Mar 21, 2023 via email

@zhi-wang
Copy link
Member

Your questions are answered in the relevant paragraphs in the updated documentation. https://github.com/TinkerTools/tinker9/blob/master/doc/manual/m/install/buildwithcmake.rst

And if you really want to use c++14, you can try cmake ... -DSTD=14 or std=14 cmake ... as documented in the "Configure Tinker9" section. I agree they look like commands such as clang++ -c -std=c++14 ..., but please note that -DSTD=/std= is the hook I added in the CMake scripts for Tinker9, and is passed to CMake. We do not directly handle Makefile. Setting syntax standards for CUDA and OpenACC compilers may be different for different compilers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants