Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to deal with unseen entities in WN18RR and FB15K237? #21

Closed
boyang-nlp opened this issue May 13, 2018 · 1 comment
Closed

How to deal with unseen entities in WN18RR and FB15K237? #21

boyang-nlp opened this issue May 13, 2018 · 1 comment

Comments

@boyang-nlp
Copy link

Hi, I have noticed that test.txt/valid.txt of WN18RR and FB15K237 contains entities that are not appear at train.txt,. It means that these entities will never be updated during the training, how to deal with these unseen entities?

@TimDettmers
Copy link
Owner

Thank you for noting this an opening an issue. Other people also recognized this issue and so I copy a reply from previous issues:

I was unaware of this when I designed the dataset. Currently, it would be consistent with other work, if you just treat these entities as any other. This falsely inflates the error rates, but if everyone treats this in the same manner there are no problems — we just need to be able to compare scores between models.

Please also see #6 for an extended discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants