Fix AbsoluteMin.getMinValue to compare by absolute magnitude, not raw value

Author: kush2439p

src/main/java/com/thealgorithms/maths/AbsoluteMin.java

@@ -1,26 +1,30 @@
-package com.thealgorithms.maths;
-
-import java.util.Arrays;
-
+package com.thealgorithms.maths;
+
 public final class AbsoluteMin {
-    private AbsoluteMin() {
-    }
-
-    /**
-     * Compares the numbers given as arguments to get the absolute min value.
-     *
-     * @param numbers The numbers to compare
-     * @return The absolute min value
-     */
-    public static int getMinValue(int... numbers) {
-        if (numbers.length == 0) {
-            throw new IllegalArgumentException("Numbers array cannot be empty");
+    private AbsoluteMin() {
+    }
+
+    /**
+     * Compares the numbers given as arguments to get the absolute min value.
+     *
+     * @param numbers The numbers to compare
+     * @return The absolute min value
+     */
+    public static int getMinValue(int... numbers) {
+        if (numbers.length == 0) {
+            throw new IllegalArgumentException("Numbers array cannot be empty");
+        }
+
+        int minValue = numbers[0];
+        for (int number : numbers) {
+            long absoluteNumber = Math.abs((long) number);
+            long absoluteMinValue = Math.abs((long) minValue);
+            if (absoluteNumber < absoluteMinValue
+                || (absoluteNumber == absoluteMinValue && number < minValue)) {
+                // For equal absolute values, consistently choose the numerically smaller value.
+                minValue = number;
+            }
         }
-
-        var absMinWrapper = new Object() { int value = numbers[0]; };
-
-        Arrays.stream(numbers).skip(1).filter(number -> Math.abs(number) <= Math.abs(absMinWrapper.value)).forEach(number -> absMinWrapper.value = Math.min(absMinWrapper.value, number));
-
-        return absMinWrapper.value;
+        return minValue;
     }
 }

src/test/java/com/thealgorithms/maths/AbsoluteMinTest.java

@@ -1,26 +1,30 @@
-package com.thealgorithms.maths;
-
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertThrows;
-
-import org.junit.jupiter.api.Test;
-
-public class AbsoluteMinTest {
-
+package com.thealgorithms.maths;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+import org.junit.jupiter.api.Test;
+
+public class AbsoluteMinTest {
+
     @Test
     void testGetMinValue() {
+        assertEquals(2, AbsoluteMin.getMinValue(-5, 2));
         assertEquals(0, AbsoluteMin.getMinValue(4, 0, 16));
         assertEquals(-2, AbsoluteMin.getMinValue(3, -10, -2));
-    }
-
-    @Test
-    void testGetMinValueWithNoArguments() {
-        Exception exception = assertThrows(IllegalArgumentException.class, AbsoluteMin::getMinValue);
-        assertEquals("Numbers array cannot be empty", exception.getMessage());
-    }
-
-    @Test
+        assertEquals(-2, AbsoluteMin.getMinValue(-5, -2));
+        assertEquals(2, AbsoluteMin.getMinValue(5, 2));
+    }
+
+    @Test
+    void testGetMinValueWithNoArguments() {
+        Exception exception = assertThrows(IllegalArgumentException.class, AbsoluteMin::getMinValue);
+        assertEquals("Numbers array cannot be empty", exception.getMessage());
+    }
+
+    @Test
     void testGetMinValueWithSameAbsoluteValues() {
+        assertEquals(-3, AbsoluteMin.getMinValue(-3, 3));
         assertEquals(-5, AbsoluteMin.getMinValue(-5, 5));
         assertEquals(-5, AbsoluteMin.getMinValue(5, -5));
     }