Merge pull request #87 from Testlio/bugfix/larger-lambda-deploys-fail/OPS-98

OPS-98: Fix TooManyRequestsException deployment failures for larger services

Author: Matten Mätlik

lib/cf-resources/lambda-version-resource/index.js

@@ -19,6 +19,7 @@ function getRandomInt(max) {
  * @return {Promise} which resolves into the function configuration
  */
 function getFunction(name) {
+    console.log('Function name: ', name);
     return new Promise((resolve, reject) => {
         lambda.getFunctionConfiguration({
             FunctionName: name
@@ -36,6 +37,7 @@ function getFunction(name) {
  */
 function getFunctionVersions(name, marker) {
     // Grab functions
+    console.log('Function versions: ', name);
     return new Promise((resolve, reject) => {
         lambda.listVersionsByFunction({
             FunctionName: name,
@@ -61,6 +63,7 @@ function getFunctionVersions(name, marker) {
  * @return {Promise} which resolves into the newly published version
  */
 function functionPublishVersion(name, description, hash) {
+    console.log('Publishing function version: ', name);
     return new Promise((resolve, reject) => {
         lambda.publishVersion({
             FunctionName: name,
@@ -100,21 +103,24 @@ exports.handler = function(event, context) {
         return response.send(event, context, response.SUCCESS, {});
     }
 
-    // Grab the function first
-    getFunction(properties.FunctionName).then(function(fn) {
-        // Then grab all versions
-        return getFunctionVersions(fn.FunctionName).then((versions) => {
-            // Try to find one that matches the function configuration
-            versions = versions.filter((version) => {
-                // Ignore the latest pseudo-version
-                return version.Version !== '$LATEST';
-            });
+    // Artificial delay to prevent deploys from hitting internal AWS API limits
+    delay(getRandomInt(15000)).then(() => {
+        // Grab the function first
+        return getFunction(properties.FunctionName).then(function(fn) {
+            // Then grab all versions
+            return getFunctionVersions(fn.FunctionName).then((versions) => {
+                // Try to find one that matches the function configuration
+                versions = versions.filter((version) => {
+                    // Ignore the latest pseudo-version
+                    return version.Version !== '$LATEST';
+                });
 
-            const trimmedFn = _.pick(fn, 'LastModified');
-            return {
-                fn: fn,
-                version: _.find(versions, trimmedFn)
-            };
+                const trimmedFn = _.pick(fn, 'LastModified');
+                return {
+                    fn: fn,
+                    version: _.find(versions, trimmedFn)
+                };
+            });
         });
     }).then((results) => {
         return delay(getRandomInt(5000)).then(function() {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "lambda-tools",
-  "version": "3.5.5",
+  "version": "3.5.7",
   "description": "Scripts for working with AWS Lambda backed microservices",
   "main": "",
   "scripts": {