The server administrator should set fewer items.

The oauth icon is excluded from setting items because there is no flexibility in adding to setting items.

Author: Tadayuki Onishi

config.inc.php

@@ -465,7 +465,6 @@
 // $tlCfg->OAuthServers[1]['oauth_name'] = 'google';
 
 // Get from /gui/themes/default/images
-// $tlCfg->OAuthServers[1]['oauth_icon'] = 'google.png'; 
 // $tlCfg->OAuthServers[1]['oauth_client_id'] = 'CLIENT_ID';
 // $tlCfg->OAuthServers[1]['oauth_client_secret'] = 'CLIENT_SECRET';
 // Can be authorization_code (by default), client_credentials or password
@@ -482,7 +481,6 @@
 // Github
 // $tlCfg->OAuthServers[2]['oauth_enabled'] = true;
 // $tlCfg->OAuthServers[2]['oauth_name'] = 'github';
-// $tlCfg->OAuthServers[2]['oauth_icon'] = 'github.png'; //Get from /gui/themes/default/images
 // $tlCfg->OAuthServers[2]['oauth_client_id'] = 'CLIENT_ID';
 // $tlCfg->OAuthServers[2]['oauth_client_secret'] = 'CLIENT_SECRET';
 
@@ -499,7 +497,6 @@
 //Microsoft
 //$tlCfg->OAuthServers[1]['oauth_enabled'] = true;
 //$tlCfg->OAuthServers[1]['oauth_name'] = 'microsoft';
-//$tlCfg->OAuthServers[1]['oauth_icon'] = 'mslogo.jpg';
 //$tlCfg->OAuthServers[1]['oauth_client_id'] = 'CLIENT_ID';
 //$tlCfg->OAuthServers[1]['oauth_client_secret'] = 'CLIENT_SECRET';
 
@@ -522,7 +519,6 @@
 
 // $tlCfg->OAuthServers[1]['oauth_enabled'] = true;
 // $tlCfg->OAuthServers[1]['oauth_name'] = 'azuread'; //do not change this
-// $tlCfg->OAuthServers[1]['oauth_icon'] = 'azuread.png'; 
 
 // $tlCfg->OAuthServers[1]['oauth_client_id'] = 'CLIENT_ID';
 // $tlCfg->OAuthServers[1]['oauth_client_secret'] = 'CLIENT_SECRET';

custom_config.inc.php.example

@@ -94,7 +94,6 @@
 // $tlCfg->authentication['oauth'][1]['oauth_name'] = 'google';
 
 // Get from /gui/themes/default/images
-// $tlCfg->authentication['oauth'][1]['oauth_icon'] = 'google.png'; 
 // $tlCfg->authentication['oauth'][1]['oauth_client_id'] = 'CLIENT_ID';
 // $tlCfg->authentication['oauth'][1]['oauth_client_secret'] = 'CLIENT_SECRET';
 // Can be authorization_code (by default), client_credentials or password
@@ -111,7 +110,6 @@
 // Github
 // $tlCfg->authentication['oauth'][2]['oauth_enabled'] = true;
 // $tlCfg->authentication['oauth'][2]['oauth_name'] = 'github';
-// $tlCfg->authentication['oauth'][2]['oauth_icon'] = 'github.png'; //Get from /gui/themes/default/images
 // $tlCfg->authentication['oauth'][2]['oauth_client_id'] = 'CLIENT_ID';
 // $tlCfg->authentication['oauth'][2]['oauth_client_secret'] = 'CLIENT_SECRET';
 

custom_config.inc.php.example.github_oauth

@@ -2,7 +2,6 @@
 # ngrok http -region eu -subdomain=testlink 80
 $tlCfg->OAuthServers[2]['oauth_enabled'] = true;
 $tlCfg->OAuthServers[2]['oauth_name'] = 'github';
-$tlCfg->OAuthServers[2]['oauth_icon'] = 'github.png';
 
 $tlCfg->OAuthServers[2]['oauth_client_id'] = '98e37f6f3f91602e9538';
 $tlCfg->OAuthServers[2]['oauth_client_secret'] = 'b66f036df4210af08a5d7b7fbf564e731e0ff189';

custom_config.inc.php.github.testlinkOauthProvider

@@ -15,7 +15,6 @@ $tlCfg->OAuthServers[2]['oauth_client_secret'] =
 
 $tlCfg->OAuthServers[2]['oauth_enabled'] = true;
 $tlCfg->OAuthServers[2]['oauth_name'] = 'github';
-$tlCfg->OAuthServers[2]['oauth_icon'] = 'github.png';
 
 // Can be authorization_code (by default), client_credentials or password
 $tlCfg->OAuthServers[2]['oauth_grant_type'] = 'authorization_code';  

custom_config.inc.php.google_oauth

@@ -19,7 +19,6 @@
 // $tlCfg->authentication['oauth'][1]['oauth_name'] = 'google';
 
 // Get from /gui/themes/default/images
-// $tlCfg->authentication['oauth'][1]['oauth_icon'] = 'google.png'; 
 // Can be authorization_code (by default), client_credentials or password
 // $tlCfg->authentication['oauth'][1]['oauth_grant_type'] = 'authorization_code';  
 // $tlCfg->authentication['oauth'][1]['oauth_url'] = 'https://accounts.google.com/o/oauth2/auth';

gui/themes/default/images/microsoft.png

@@ -226,7 +226,7 @@ function init_gui(&$db,$args) {
         $gui->oauth[$name] = new stdClass();
         $gui->oauth[$name]->name = ucfirst($name);
         $gui->oauth[$name]->link = oauth_link($oauth_prov);
-        $gui->oauth[$name]->icon = $oauth_prov['oauth_icon'];
+        $gui->oauth[$name]->icon = $name . '.png';
     }
   }
 

gui/themes/default/images/mslogo.jpg

@@ -151,7 +151,7 @@ function init_gui(&$db,$args)
         $gui->oauth[$name] = new stdClass();
         $gui->oauth[$name]->name = ucfirst($name);
         $gui->oauth[$name]->link = oauth_link($oauth_prov);
-        $gui->oauth[$name]->icon = $oauth_prov['oauth_icon'];
+        $gui->oauth[$name]->icon = $name . '.png';
     }
   }
   $gui->external_password_mgmt = false;