Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hat-trie behaves wrong when burst-threshold is set to 65536 or larger #54

Open
liuxiaochuang opened this issue Feb 21, 2024 · 1 comment

Comments

@liuxiaochuang
Copy link

When the burst-threshold is set to smaller than 65536, the hat-trie behaves normally, and memory usage is 32%. However, when set to 65536 or larger, it causes my process to coredump, with memory usage only at 24%. Why is that?

@Tessil
Copy link
Owner

Tessil commented Aug 26, 2024

Thanks for the report.

There's effectively a limit of 65535 due to the IndexSizeT of uint16 used for the array_hash of the htrie_hash.

I added a check in commit 611bdcc. Previously, an exception should have been thrown if we were inserting more than 65535 elements. Did you get a segfault instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants