Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mod to Minecraft 1.20.5 #723

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

haykam821
Copy link
Contributor

This pull request updates the mod to Minecraft 1.20.5 by changing values in gradle.properties. The existing beta release built using Minecraft 1.20.5 release candidate 3 should already work.

This version seems to currently support Minecraft 1.20.5 pre-release 2 through Minecraft 1.20.6 release candidate 1, as Minecraft 1.20.5 pre-release 1 crashes on launch due to an incompatible mixin within bundled Fabric API dependencies:

[Render thread/ERROR]: Mixin apply for mod fabric-resource-loader-v0 failed fabric-resource-loader-v0.mixins.json:MinecraftServerMixin from mod fabric-resource-loader-v0 -> net.minecraft.server.MinecraftServer: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException Critical injection failure: @Redirect annotation on onCheckDisabled could not find any targets matching 'Lnet/minecraft/server/MinecraftServer;method_29736(Lnet/minecraft/class_3283;Lnet/minecraft/class_7712;ZZ)Lnet/minecraft/class_7712;' in net.minecraft.server.MinecraftServer. Using refmap fabric-resource-loader-v0-refmap.json [PREINJECT Applicator Phase -> fabric-resource-loader-v0.mixins.json:MinecraftServerMixin from mod fabric-resource-loader-v0 -> Prepare Injections ->  -> redirect$zbb000$fabric-resource-loader-v0$onCheckDisabled(Ljava/util/List;Ljava/lang/Object;Lnet/minecraft/class_3283;)Z -> Parse]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @Redirect annotation on onCheckDisabled could not find any targets matching 'Lnet/minecraft/server/MinecraftServer;method_29736(Lnet/minecraft/class_3283;Lnet/minecraft/class_7712;ZZ)Lnet/minecraft/class_7712;' in net.minecraft.server.MinecraftServer. Using refmap fabric-resource-loader-v0-refmap.json [PREINJECT Applicator Phase -> fabric-resource-loader-v0.mixins.json:MinecraftServerMixin from mod fabric-resource-loader-v0 -> Prepare Injections ->  -> redirect$zbb000$fabric-resource-loader-v0$onCheckDisabled(Ljava/util/List;Ljava/lang/Object;Lnet/minecraft/class_3283;)Z -> Parse]

CurseForge does not have a 1.20.6-Snapshot version, so preliminary Minecraft 1.20.6 support will not be marked on CurseForge.

@Prospector Prospector merged commit 61cc949 into TerraformersMC:1.20.5 Jun 15, 2024
1 check passed
@haykam821 haykam821 deleted the update-1.20.5 branch June 15, 2024 18:18
@haykam821 haykam821 added the port A PR that updates the game version label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port A PR that updates the game version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants