Skip to content

getting schema names #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ofajardo opened this issue Feb 2, 2019 · 2 comments
Open

getting schema names #82

ofajardo opened this issue Feb 2, 2019 · 2 comments

Comments

@ofajardo
Copy link

ofajardo commented Feb 2, 2019

hi

I am puzzled about the behavior of get_schema_names in dialect.py. I was expecting it to retrieve all the schemas/databases in the system but instead of that only retrieves your username. What is the intention or usefulness of doing that?
Because I am connecting teradata to Apache superset, I needed that get_schema_names gives back the databases/schemas for SQL Lab to display them. I changed the function to look at DBC.Databases2V and it works like a charm.
If there is interest I can submit a PR.

thanks

@sandan
Copy link
Member

sandan commented Feb 11, 2019

A PR would be appreciated! I think there was confusion over which schemas to return.

@ofajardo
Copy link
Author

PR submitted (#83)
The tests do not look straightforward, I commented that point in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants