Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Pre-Commit Configuration Stays Updated with Future Python & PIP Upgrades #587

Open
ChasVanDav opened this issue Feb 10, 2025 · 2 comments
Labels
dependencies Pull requests that update a dependency file 👩🏽‍💻 returning-grad

Comments

@ChasVanDav
Copy link
Collaborator

Description

Following the recent update of Black to v24.8.0 and Click to v8.1.8 (PR #525 & #565), @monikkaelyse pointed out the need to review the entire pre-commit configuration in light of the upcoming Python and PIP upgrades. This will help ensure compatibility and prevent future issues.

Why This Matters

The latest Black update resolved compatibility issues with Click.
However, upcoming changes to Python/PIP may require additional updates.
Keeping dependencies aligned will prevent broken builds and runtime errors.

Tasks to Complete

  • Review the pre-commit YAML file to identify other dependencies that may need updating.
  • Cross-check the current pre-commit hooks against the latest Python & PIP versions.
  • Determine if future updates will require additional modifications.
  • Update documentation (if necessary) to reflect best practices for maintaining pre-commit dependencies.

Related Issues & PRs

#525 – Black version incompatibility with Click
#565 – Merged fix for Black/Click

Note: This issue is marked as "Not Ready for Work" until the Python and PIP upgrades are completed.

@ChasVanDav ChasVanDav added dependencies Pull requests that update a dependency file ❌ not-ready-for-work this issue is not ready to be picked up 👩🏽‍💻 returning-grad labels Feb 10, 2025
@ChasVanDav
Copy link
Collaborator Author

@daaimah123 @monikkaelyse fyi, this issue has been created in anticipation for the impending Python & PIP upgrades. Feel free to update the tag when dependencies should be upgraded. Thank you!

@daaimah123 daaimah123 added the blocked work on this task is blocked label Feb 10, 2025
@monikkaelyse
Copy link
Collaborator

monikkaelyse commented Feb 10, 2025

@daaimah123 @ChasVanDav This work can be started now, please branch off of the python upgrade branch origin/issue-519-upgrade-python . You will need to create a new virtual environment for this branch using the latest python and pip as indicated in the parent ticket PR.

# Remove your venv directory
rm -r venv
# Use pyenv to install new version of Python
pyenv install 3.13.1
# Set your python version to 3.13.1
pyenv local 3.13.1
# Create a virtual environment using venv
python -m venv venv
# Activate your new virtual environment
source venv/bin/activate
# Verify pip version
pip --version
# If it is not the latest version 24.3.1, upgrade pip
pip install --upgrade pip 
# Install and upgrade pip-tools
python -m pip install -U pip-tools
# Install dev requirements
pip install -r dev.txt

@monikkaelyse monikkaelyse removed ❌ not-ready-for-work this issue is not ready to be picked up blocked work on this task is blocked labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file 👩🏽‍💻 returning-grad
Projects
None yet
Development

No branches or pull requests

3 participants