Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert code challenges tests from jasmine -> jest #1572

Closed
alodahl opened this issue Jun 20, 2021 · 8 comments
Closed

Convert code challenges tests from jasmine -> jest #1572

alodahl opened this issue Jun 20, 2021 · 8 comments
Labels
EASY Quick or simple task wontfix

Comments

@alodahl
Copy link
Collaborator

alodahl commented Jun 20, 2021

Our code challenges repo is currently using jasmine. We have a lot of very short, simple unit tests. Please convert our repo and tests to run using jest instead. Also update our package.json test command to use any new jest command. If you needed to change any commands, directory or file names, please leave a note about it here.

@alodahl alodahl added priority get this done first if possible EASY Quick or simple task labels Jun 20, 2021
@ndp
Copy link
Collaborator

ndp commented Jun 21, 2021

It would be nice to remove the node_modules from the git repo, but I'm just leaving it for now. I can do that here or as a separate PR on request.

@ndp
Copy link
Collaborator

ndp commented Jun 22, 2021

The PR is found here: Techtonica/code-challenges#12

@alodahl
Copy link
Collaborator Author

alodahl commented Jun 22, 2021

removing node mods would be great - that was an oversight.

@alodahl alodahl removed the priority get this done first if possible label Jun 24, 2021
@ndp
Copy link
Collaborator

ndp commented Jun 25, 2021

@alodahl you want me to do that in this PR? or a subsequent one?

If you merge this, I create another one that removes node_modules and has instructions for installation.

@ndp
Copy link
Collaborator

ndp commented Jun 26, 2021

Nevermind... here is a node_modules PR: Techtonica/code-challenges#13

@stale
Copy link

stale bot commented Sep 24, 2021

Although it may very well be a good idea, this issue has not had recent activity and is unlikely to be worked on. Consider creating your own pull request for the issue if that is feasible. If no further activity occurs, this will be closed in 14 days. Thank you for your contribution.

@stale stale bot added the wontfix label Sep 24, 2021
@alodahl
Copy link
Collaborator Author

alodahl commented Oct 3, 2021

it sounds like we wont be using the code challenges anymore, or at least this isnt a priority.

@stale stale bot removed the wontfix label Oct 3, 2021
@stale
Copy link

stale bot commented Jan 4, 2022

Although it may very well be a good idea, this issue has not had recent activity and is unlikely to be worked on. Consider creating your own pull request for the issue if that is feasible. If no further activity occurs, this will be closed in 14 days. Thank you for your contribution.

@stale stale bot added the wontfix label Jan 4, 2022
@stale stale bot closed this as completed Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EASY Quick or simple task wontfix
Projects
None yet
Development

No branches or pull requests

2 participants