Skip to content

Commit 51288cb

Browse files
Merge pull request #9515 from crimson-knight/master
[crystal] Updates to the README and small change to improve the connection pool…
2 parents c0233da + 881b3a2 commit 51288cb

File tree

4 files changed

+8
-53
lines changed

4 files changed

+8
-53
lines changed

frameworks/Crystal/amber/README.md

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,12 @@ This is the [Amber](https://amberframework.org) test of the Framework Benchmarks
88

99
The purpose of Amber is not to create yet another framework, but to take advantage of the beautiful Crystal language capabilities and provide engineers an efficient, cohesive, and well maintain web framework for the crystal community that embraces the language philosophies, conventions, and guides.
1010

11-
Amber Crystal borrows concepts that already have been battle tested, successful, and embrace new concepts through team and community collaboration and analysis, that aligns with Crystal philosophies.
11+
Amber borrows concepts that already have been battle tested, successful, and embrace new concepts through team and community collaboration and analysis, that aligns with Crystal philosophies.
1212

13-
## Contributors
13+
Updated for Amber 1.4.1 and Crystal 1.14.0
1414

15-
- Dru Jensen [drujensen](https://github.com/drujensen)
16-
- Elias Perez [eliasjpr](https://github.com/eliasjpr)
17-
- Isaac Sloan [elorest](https://github.com/elorest)
18-
- Faustino Aguilar [faustinoaq](https://github.com/faustinoaq)
19-
- Nick Franken [fridgerator](https://github.com/fridgerator)
20-
- Mark Siemers [marksiemers](https://github.com/marksiemers)
21-
- Robert Carpenter [robacarp](https://github.com/robacarp)
15+
## Contributors
16+
- Seth Tucker [crimson-knight](https://github.com/crimson-knight)
2217

2318
See more [Amber contributors](https://github.com/amberframework/amber/graphs/contributors)
2419

frameworks/Crystal/amber/config/initializers/database.cr

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
require "granite/adapter/pg"
22

3-
cpu_count = System.cpu_count
4-
pool_size = 56 // cpu_count
3+
cpu_count = System.cpu_count - 1 # Always leave 1 core for the system
4+
pool_size = cpu_count * 4 # 4x the number of cores, should be plenty of room for concurrency
55
database_url = ENV["DATABASE_URL"]
66
url = "#{database_url}?initial_pool_size=#{pool_size}&max_idle_pool_size=#{pool_size}"
77

frameworks/Crystal/amber/shard.lock

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,6 @@ shards:
2828
git: https://github.com/crystal-lang/crystal-db.git
2929
version: 0.11.0
3030

31-
dotenv:
32-
git: https://github.com/gdotdesign/cr-dotenv.git
33-
version: 1.0.0
34-
3531
exception_page:
3632
git: https://github.com/crystal-loot/exception_page.git
3733
version: 0.3.1
@@ -44,22 +40,10 @@ shards:
4440
git: https://github.com/amberframework/granite.git
4541
version: 0.23.3
4642

47-
i18n:
48-
git: https://github.com/crimson-knight/i18n.cr.git
49-
version: 0.4.1
50-
51-
ifrit:
52-
git: https://github.com/imdrasil/ifrit.git
53-
version: 0.1.3
54-
5543
inflector:
5644
git: https://github.com/phoffer/inflector.cr.git
5745
version: 1.0.0
5846

59-
jennifer:
60-
git: https://github.com/imdrasil/jennifer.cr.git
61-
version: 0.13.0
62-
6347
json_mapping:
6448
git: https://github.com/crystal-lang/json_mapping.cr.git
6549
version: 0.1.1
@@ -74,15 +58,15 @@ shards:
7458

7559
micrate:
7660
git: https://github.com/amberframework/micrate.git
77-
version: 0.15.0
61+
version: 0.15.1
7862

7963
mysql:
8064
git: https://github.com/crystal-lang/crystal-mysql.git
8165
version: 0.14.0
8266

8367
optarg:
8468
git: https://github.com/amberframework/optarg.git
85-
version: 0.9.3
69+
version: 0.9.5
8670

8771
pg:
8872
git: https://github.com/will/crystal-pg.git
@@ -96,10 +80,6 @@ shards:
9680
git: https://github.com/stefanwille/crystal-redis.git
9781
version: 2.8.3
9882

99-
sam:
100-
git: https://github.com/imdrasil/sam.cr.git
101-
version: 0.5.0
102-
10383
shell-table:
10484
git: https://github.com/luckyframework/shell-table.cr.git
10585
version: 0.9.3
@@ -116,10 +96,6 @@ shards:
11696
git: https://github.com/amberframework/teeplate.git
11797
version: 0.11.2
11898

119-
wordsmith:
120-
git: https://github.com/luckyframework/wordsmith.git
121-
version: 0.4.0
122-
12399
yaml_mapping:
124100
git: https://github.com/crystal-lang/yaml_mapping.cr.git
125101
version: 0.1.1

frameworks/Crystal/amber/shard.yml

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,26 +15,10 @@ dependencies:
1515
github: amberframework/amber
1616
version: 1.4.1
1717

18-
jennifer:
19-
github: imdrasil/jennifer.cr
20-
version: "~> 0.13.0"
21-
22-
sam:
23-
github: imdrasil/sam.cr
24-
version: 0.5.0
25-
2618
pg:
2719
github: will/crystal-pg
2820
version: "= 0.26.0"
2921

30-
mysql:
31-
github: crystal-lang/crystal-mysql
32-
version: 0.14.0
33-
34-
dotenv:
35-
github: gdotdesign/cr-dotenv
36-
version: 1.0.0
37-
3822
granite:
3923
github: amberframework/granite
4024
version: 0.23.3

0 commit comments

Comments
 (0)