Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control + right clicking on items in REI to quick craft them in the compressor/circuit fabricator consumes any surplus items #405

Open
Roelymole opened this issue Jan 29, 2025 · 1 comment

Comments

@Roelymole
Copy link
Contributor

Version Information

2228bc6

Log or Crash Report

No response

Reproduction steps

  1. Put the required ingredients for crafting multiple items in the compressor/circuit fabricator i.e. a stack of iron to craft 32 compressed iron.

  2. Find the item you wish to craft in REI and hover over it. You should see the tooltip "Ctrl-Click to Quick Craft".

Image

  1. Pressing control + left click will take the ingredients required to craft a single item and arrange them in the machine according to the recipe.

Image

  1. Pressing control + right click will take the ingredients required to craft as many of the item as possible, but only inserts the ingredients required to craft a single item and the surplus are consumed, whereas for this example there should be 32 iron in the first and second slot of the compressor.

Image

@Roelymole
Copy link
Contributor Author

I think that making sure that CompressorMenu and CircuitFabricatorMenu also extend RecipeBookMenu might be required to fix this, however this might be quite fiddly to do since CompressorMenu and CircuitFabricatorMenu already extend RecipeMachineMenu from MachineLib.

Roelymole added a commit to Roelymole/Galacticraft that referenced this issue Jan 29, 2025
Roelymole added a commit that referenced this issue Feb 3, 2025
…y to match the current Circuit Fabricator/Compressor GUIs (#408)

* chore: updated recipe viewer compatiability to match the current compressor and circuit fabricator GUIs

* chore: set the circuit fabricator/compressor recipes to special to prevent the unknown recipe category messages

* chore: no longer use deprecated REI methods

* chore: add RecipeBookTypes for Circuit Fabricator and Compressor to be used when extending RecipeBookMenu for #405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant