change: delay loading dynamic dimensions until all normal dimensions are loaded

Author: marcus8448

README.md

@@ -69,7 +69,7 @@ DimensionType type;
 // ... initialize chunk generator and dimension type ...
 
 DynamicDimensionRegistry registry = DynamicDimensionRegistry.from(server);
-ServerLevel level = registry.createDynamicDimension(new ResourceLocation("mymod", "dynamic"), generator, type);
+ServerLevel level = registry.createDynamicDimension(ResourceLocation.fromNamespaceAndPath("mymod", "dynamic"), generator, type);
 
 if (level == null) {
     // failed to create level
@@ -98,7 +98,7 @@ DimensionType type;
 // ... initialize chunk generator and dimension type ...
 
 DynamicDimensionRegistry registry = DynamicDimensionRegistry.from(server);
-ServerLevel level = registry.loadDynamicDimension(new ResourceLocation("mymod", "dynamic"), generator, type);
+ServerLevel level = registry.loadDynamicDimension(ResourceLocation.fromNamespaceAndPath("mymod", "dynamic"), generator, type);
 
 if (level == null) {
     // failed to create level
@@ -118,7 +118,7 @@ Call
 with the ID of your dimension and (optionally) a callback to move connected players off-world.
 ```java
 DynamicDimensionRegistry registry = DynamicDimensionRegistry.from(server);
-registry.unloadDynamicDimension(new ResourceLocation("mymod", "dynamic"), null);
+registry.unloadDynamicDimension(ResourceLocation.fromNamespaceAndPath("mymod", "dynamic"), null);
 ```
 The dimension will be saved to disk before being unloaded. You can use
 `loadDynamicDimension`
@@ -133,7 +133,7 @@ Call
 with the ID of your dimension and (optionally) a callback to move connected players off-world.
 ```java
 DynamicDimensionRegistry registry = DynamicDimensionRegistry.from(server);
-registry.deleteDynamicDimension(new ResourceLocation("mymod", "dynamic"), null);
+registry.deleteDynamicDimension(ResourceLocation.fromNamespaceAndPath("mymod", "dynamic"), null);
 ```
 The dimension will be unloaded, then all the dimension files will be deleted.
 

common/src/main/java/dev/galacticraft/dynamicdimensions/api/event/DynamicDimensionLoadCallback.java

@@ -31,7 +31,7 @@
 import org.jetbrains.annotations.NotNull;
 
 /**
- * Called when a dynamic dimension is added.
+ * Called when dynamic dimensions should be loaded from the server.
  *
  * @since 0.5.0
  */

common/src/main/java/dev/galacticraft/dynamicdimensions/impl/mixin/MinecraftServerMixin.java

@@ -35,8 +35,6 @@
 import dev.galacticraft.dynamicdimensions.impl.internal.DimensionRemovalTicket;
 import dev.galacticraft.dynamicdimensions.impl.network.S2CPackets;
 import dev.galacticraft.dynamicdimensions.impl.registry.RegistryUtil;
-import io.netty.buffer.Unpooled;
-import lol.bai.badpackets.api.PacketSender;
 import net.minecraft.core.Holder;
 import net.minecraft.core.LayeredRegistryAccess;
 import net.minecraft.core.Registry;
@@ -45,7 +43,6 @@
 import net.minecraft.nbt.CompoundTag;
 import net.minecraft.nbt.NbtOps;
 import net.minecraft.nbt.Tag;
-import net.minecraft.network.FriendlyByteBuf;
 import net.minecraft.network.protocol.common.ClientboundUpdateTagsPacket;
 import net.minecraft.resources.ResourceKey;
 import net.minecraft.resources.ResourceLocation;
@@ -205,7 +202,7 @@ private void registerLevel(ServerLevel level) {
         level.tick(() -> true);
     }
 
-    @Inject(method = "tickChildren", at = @At(value = "INVOKE", target = "Lnet/minecraft/server/ServerFunctionManager;tick()V", shift = At.Shift.AFTER))
+    @Inject(method = "tickChildren", at = @At(value = "INVOKE", target = "Lnet/minecraft/server/MinecraftServer;getAllLevels()Ljava/lang/Iterable;", shift = At.Shift.BEFORE))
     private void markTickingLevels(BooleanSupplier booleanSupplier, CallbackInfo ci) {
         this.tickingLevels = true;
     }
@@ -215,7 +212,7 @@ private void markNotTickingLevels(BooleanSupplier booleanSupplier, CallbackInfo
         this.tickingLevels = false;
     }
 
-    @Inject(method = "createLevels", at = @At(value = "INVOKE", target = "Lnet/minecraft/core/Registry;entrySet()Ljava/util/Set;", shift = At.Shift.BEFORE))
+    @Inject(method = "createLevels", at = @At(value = "INVOKE", target = "Lnet/minecraft/world/level/border/WorldBorder;applySettings(Lnet/minecraft/world/level/border/WorldBorder$Settings;)V", shift = At.Shift.BEFORE))
     private void loadDynamicDimensions(CallbackInfo ci) {
         final Registry<DimensionType> typeRegistry = this.registryAccess().registryOrThrow(Registries.DIMENSION_TYPE);
         final Registry<LevelStem> stemRegistry = this.registries().compositeAccess().registryOrThrow(Registries.LEVEL_STEM);

gradle.properties

@@ -6,7 +6,7 @@ mod.id=dynamicdimensions
 mod.name=Dynamic Dimensions
 mod.description=Library to facilitate the runtime addition and removal of Minecraft dimensions.
 mod.license=MIT
-mod.version=0.7.0
+mod.version=0.8.0
 
 # Loader dependencies
 minecraft.version=1.21