Added lots of Element finding tests and fixed errors

Author: Mat Walker

src/main/java/TeamControlium/Controlium/HTMLElement.java

@@ -39,8 +39,9 @@ public HTMLElement() {
 
     public HTMLElement(Object parent, WebElement underlyingWebElement, ObjectMapping mapping) {
         setParentOfThisElement(parent);
-        setSeleniumWebElement(underlyingWebElement);
         setMappingDetails(mapping);
+        setSeleniumWebElement(underlyingWebElement);
+
     }
 
 

src/main/java/TeamControlium/Controlium/ObjectMapping.java

@@ -32,11 +32,11 @@ private void InitObjectMap(String findLogic, String friendlyName)
     {
         this._findLogicOriginal = findLogic;
         _friendlyNameOriginal = (friendlyName==null) ? findLogic : friendlyName;
-        _friendlyName = null;
+        _friendlyName = _friendlyNameOriginal;
     }
 
 
-    public ByType getMappingType() { return _mappingType; }
+    public ByType getMappingType() { if (_mappingType==null) processFindLogic((_findLogicActual==null)?_findLogicOriginal:_findLogicActual); return _mappingType; }
 
 
 
@@ -97,17 +97,7 @@ public String getFriendlyName() {
     public ObjectMapping copy() {
         try {
             //
-            // We do a dodgy here.  When copying a mapping we want to reset the Actual Find Logic as the copy has not yet been used
-            // and may be part of being built (IE. from FindElements).  So we want to clear the Actual Find Logic which cannot be done
-            // publically (obviously!).  So, we temporarily clear the actual find logic and then put it back after the clone...
-            //
-            // Note.  In Java Strings are immutable, so doing the assignment works and is safe.  Note though that this no way
-            //        thread-safe!!
-            //
-            String originalActualFindLogic = _findLogicActual;
-            _findLogicActual=null;
-            ObjectMapping clone = (ObjectMapping)this.clone();
-            _findLogicActual = originalActualFindLogic;
+            ObjectMapping clone = new ObjectMapping(_findLogicActual,_friendlyName);
             return clone;
         }
         catch (Exception e) {

src/main/java/TeamControlium/Controlium/SeleniumDriver.java

@@ -197,9 +197,10 @@ public HTMLElement findElement(HTMLElement parentElement,ObjectMapping objectMap
 
         Logger.WriteLine(Logger.LogLevels.TestDebug, "Timeout - %s", durationFormatted(timeout));
 
+        StopWatch timer = StopWatch.createStarted();
         while (true) {
 
-            StopWatch timer = StopWatch.createStarted();
+
 
             // Loop while:-
             //  - we have no find results
@@ -226,7 +227,7 @@ public HTMLElement findElement(HTMLElement parentElement,ObjectMapping objectMap
 
             }
             if (clauseResults.size() > 1 && !allowMultipleMatches) {
-                String errorText = String.format("Found %d matching elements using ([%s] - %s) from [%s] (Waited upto %dmS). allowMultipleMatches=false so error!",
+                String errorText = String.format("Found %d matching elements using [%s] ([%s]) from [%s]. Not allowing mutiple matches and timeout reached after [%dmS]",
                         clauseResults.size(),
                         objectMapping.getActualFindLogic(),
                         objectMapping.getFriendlyName(),
@@ -258,18 +259,18 @@ public HTMLElement findElement(HTMLElement parentElement,ObjectMapping objectMap
                     break;
                 } else {
                     if (timer.getTime()>=totalTimeoutMillis) {
-                        Logger.WriteLine(Logger.LogLevels.Error, "From [%s], find [%s (%s)] returned %d matches (%s multiple matches). We must wait until stable, element 0 is NOT stable and timeout reached so throwing",
+                        Logger.WriteLine(Logger.LogLevels.Error, "From [%s], find [%s (%s)] returned %d matches (%sllowing multiple matches). Element NOT stable after timeout reached so throwing",
                                 (parentElement == null) ? "DOM Top Level" : parentElement.getMappingDetails().getFriendlyName(),
                                 objectMapping.getActualFindLogic(),
                                 objectMapping.getFriendlyName(),
                                 clauseResults.size(),
-                                (allowMultipleMatches) ? "Allowing" : "Not");
-                        throw new RuntimeException(String.format("From [%s], find [%s (%s)] returned %d matches (%s multiple matches). We must wait until stable and element 0 NOT stable and timeout reached after %dmS.",
+                                (allowMultipleMatches) ? "A" : "Not A");
+                        throw new RuntimeException(String.format("From [%s], find [%s (%s)] returned %d matches (%sllowing multiple matches). Element NOT stable after timeout reached ([%dmS]).",
                                 (parentElement == null) ? "DOM Top Level" : parentElement.getMappingDetails().getFriendlyName(),
                                 objectMapping.getActualFindLogic(),
                                 objectMapping.getFriendlyName(),
                                 clauseResults.size(),
-                                (allowMultipleMatches) ? "Allowing" : "Not",
+                                (allowMultipleMatches) ? "A" : "Not A",
                                 timer.getTime()));
                     }
                     Logger.WriteLine(Logger.LogLevels.TestDebug, "From [%s], find [%s (%s)] returned %d matches (%s multiple matches).  Element 0 is NOT stable and we must wait until stable...",
@@ -279,6 +280,8 @@ public HTMLElement findElement(HTMLElement parentElement,ObjectMapping objectMap
                             clauseResults.size(),
                             (allowMultipleMatches) ? "Allowing" : "Not");
                 }
+            } else {
+                break;
             }
         }
         return clauseResults.get(0);
@@ -301,7 +304,15 @@ public List<HTMLElement> findElements(HTMLElement parentElement, ObjectMapping m
 
         try {
             Logger.WriteLine(Logger.LogLevels.FrameworkDebug,"Calling Selenium WebDriver findElements with By = [%s]",seleniumFindBy.toString());
-            foundElements = (parentElement==null) ? webDriver.findElements(seleniumFindBy) : parentElement.getSeleniumnWebElement().findElements(seleniumFindBy);
+            if (parentElement==null) {
+                foundElements = webDriver.findElements(seleniumFindBy);
+            }
+            else {
+                foundElements=parentElement.getSeleniumnWebElement().findElements(seleniumFindBy);
+            }
+        }
+        catch (InvalidSelectorException e) {
+            throw new RuntimeException(String.format("Selenium Driver error. Find Logic [%s] for [%s] is invalid!",mapping.getActualFindLogic(),mapping.getFriendlyName(),e));
         }
         catch (WebDriverException e)
         {
@@ -320,9 +331,9 @@ public List<HTMLElement> findElements(HTMLElement parentElement, ObjectMapping m
         }
 
         if (parentElement==null)
-            Logger.WriteLine(Logger.LogLevels.TestInformation,"Found [%d] elements matching [%s] (%s)",foundElements.size(),mapping.getOriginalFindLogic(),mapping.getFriendlyName());
+            Logger.WriteLine(Logger.LogLevels.FrameworkDebug,"Found [%d] elements matching [%s] (%s)",foundElements.size(),mapping.getOriginalFindLogic(),mapping.getFriendlyName());
         else
-            Logger.WriteLine(Logger.LogLevels.TestInformation,"Found [%d] elements matching [%s] (%s) offset from [%s]",foundElements.size(),mapping.getOriginalFindLogic(),mapping.getFriendlyName(),parentElement.getMappingDetails().getFriendlyName());
+            Logger.WriteLine(Logger.LogLevels.FrameworkDebug,"Found [%d] elements matching [%s] (%s) offset from [%s]",foundElements.size(),mapping.getOriginalFindLogic(),mapping.getFriendlyName(),parentElement.getMappingDetails().getFriendlyName());
 
 
         for(int index = 0;index<foundElements.size();index++) {
@@ -797,7 +808,7 @@ private String CallingMethodDetails(StackTraceElement methodBase)
     private void checkIfConnectionIssue(Exception e) throws RuntimeException {
         StackTraceElement[] stackTraceElements = Thread.currentThread().getStackTrace();
         StackTraceElement caller = stackTraceElements[2];
-        if (e.getCause().getClass()==ConnectException.class) {
+        if (e.getClass()==ConnectException.class) {
             throw new RuntimeException(String.format("Selenium Driver method [%s] called but Selenium WebDriver not connected!",CallingMethodDetails(caller)),e);
         }
     }