NR-270545 Not possible to make a post when 'ShowGrok' feature is off (#448)

- Mostly fix formatting to match existing formatting style
- Only real code change is `this.useId = existingPost.id;` in post_post_request.js

Author: dsellarsnr

api_server/modules/posts/post_creator.js

@@ -168,57 +168,58 @@ class PostCreator extends ModelCreator {
 			// creating a code error
 			this.creatingCodeError = true;
 		} else if (this.attributes.errorGuid) { // New style where we just associate NR error via error entity guid
-				this.request.log("errorGuid in request - looking up existing post");
-				let existingPost = await this.data.posts.getOneByQuery(
-					{ errorGuid: this.attributes.errorGuid, deactivated: false },
-					{ hint: PostIndexes.byErrorGuid }
+			this.request.log('errorGuid in request - looking up existing post');
+			let existingPost = await this.data.posts.getOneByQuery(
+				{ errorGuid: this.attributes.errorGuid, deactivated: false },
+				{ hint: PostIndexes.byErrorGuid }
+			);
+			if (!existingPost) {
+				// Check for a legacy codeError
+				this.request.log('looking for a legacy codeError');
+				const legacyCodeError = await this.data.codeErrors.getOneByQuery(
+					{ objectId: this.attributes.errorGuid, deactivated: false },
+					{ hint: CodeErrorIndexes.byObjectId}
 				);
-				if (!existingPost) {
-					// Check for a legacy codeError
-					this.request.log("looking for a legacy codeError");
-					const legacyCodeError = await this.data.codeErrors.getOneByQuery(
-						{ objectId: this.attributes.errorGuid, deactivated: false },
-						{ hint: CodeErrorIndexes.byObjectId}
-					);
-					if (legacyCodeError) {
-						this.request.log("found a legacy codeError");
-						// need to update the post with the errorGuid and not create a stream (suppressSave will get set later based on existingPost)
-						const legacyPostId = legacyCodeError.get('postId');
-						const legacyPost = await this.data.posts.getById(legacyPostId);
-						if (legacyPost.get('deactivated') !== true) {
-							legacyPost.attributes.errorGuid = this.attributes.errorGuid;
-							// legacyPost.set('errorGuid', this.attributes.errorGuid);
-							const op = {
-								$set: {
-									errorGuid: this.attributes.errorGuid,
-									modifiedAt: Date.now()
-								}
-							};
-							this.transforms.postUpdate = await new ModelSaver({
-								request: this.request,
-								collection: this.data.posts,
-								id: legacyPostId
-							}).save(op);
-							this.request.log(
-								`updated post ${legacyPostId} with errorGuid ${this.attributes.errorGuid} for legacy codeError ${legacyCodeError.get('id')}`
-							);
-							existingPost = legacyPost;
-						} else {
-							this.request.log(`skipping deactivated legacy post ${legacyPostId}`);
-						}
+				if (legacyCodeError) {
+					this.request.log('found a legacy codeError');
+					// need to update the post with the errorGuid and not create a stream (suppressSave will get set later based on existingPost)
+					const legacyPostId = legacyCodeError.get('postId');
+					const legacyPost = await this.data.posts.getById(legacyPostId);
+					if (legacyPost.get('deactivated') !== true) {
+						legacyPost.attributes.errorGuid = this.attributes.errorGuid;
+						// legacyPost.set('errorGuid', this.attributes.errorGuid);
+						const op = {
+							$set: {
+								errorGuid: this.attributes.errorGuid,
+								modifiedAt: Date.now()
+							}
+						};
+						this.transforms.postUpdate = await new ModelSaver({
+							request: this.request,
+							collection: this.data.posts,
+							id: legacyPostId
+						}).save(op);
+						this.request.log(
+							`updated post ${legacyPostId} with errorGuid ${this.attributes.errorGuid} for legacy codeError ${legacyCodeError.get('id')}`
+						);
+						existingPost = legacyPost;
+					} else {
+						this.request.log(`skipping deactivated legacy post ${legacyPostId}`);
 					}
 				}
-				if (existingPost) {
-					this.request.log(`errorGuid in request - found post, suppressing save, attributes: ${JSON.stringify(existingPost.attributes)}`);
-					this.suppressSave = true;
-					this.creatingCodeError = false;
-					this.attributes = existingPost.attributes;
-				} else {
-					this.request.log(`errorGuid in request - did not find post, creating stream with accountId ${this.attributes.accountId}`);
-					this.creatingCodeError = true;
-					await this.createStream();
-				}
-			} else if (this.attributes.parentPostId) {
+			}
+			if (existingPost) {
+				this.request.log(`errorGuid in request - found post, suppressing save, attributes: ${JSON.stringify(existingPost.attributes)}`);
+				this.suppressSave = true;
+				this.useId = existingPost.id;
+				this.creatingCodeError = false;
+				this.attributes = existingPost.attributes;
+			} else {
+				this.request.log(`errorGuid in request - did not find post, creating stream with accountId ${this.attributes.accountId}`);
+				this.creatingCodeError = true;
+				await this.createStream();
+			}
+		} else if (this.attributes.parentPostId) {
 			// is the parent a code error?
 			this.parentPost = await this.data.posts.getById(this.attributes.parentPostId);
 			if (!this.parentPost) {

api_server/modules/posts/post_post_request.js

@@ -2,7 +2,7 @@
 
 'use strict';
 
-const GrokClient = require("../../lib/grok/grok_client");
+const GrokClient = require('../../lib/grok/grok_client');
 const PostRequest = require(process.env.CSSVC_BACKEND_ROOT + '/api_server/lib/util/restful/post_request');
 
 class PostPostRequest extends PostRequest {
@@ -53,7 +53,7 @@ class PostPostRequest extends PostRequest {
 			}
 
 			const post = await this.data.posts.getById(this.request.body.parentPostId);
-			this.log("PostPostRequest - handleResponse - reinitializeGrok - looking up codeError");
+			this.log('PostPostRequest - handleResponse - reinitializeGrok - looking up codeError');
 			const codeError = await this.data.codeErrors.getById(post.get('codeErrorId'));
 
 			// When we force a reinitialization on a Code Error with Grok, we need to return