Read secrets at runtime for tests

Author: dsellarsnr

api_server/package.json

@@ -61,7 +61,7 @@
 	},
 	"scripts": {
 		"veryclean": "git clean -fXd",
-		"test": "mocha --exit",
+		"test": "mocha --exit --dev_secrets",
 		"test:ci": "npm run test -- --reporter mocha-teamcity-reporter",
 		"clean": "git clean -fXd -e !node_modules -e !node_modules/**/*",
 		"eslint": "eslint .",

api_server/test.js

@@ -2,6 +2,29 @@
 
 'use strict';
 
+// make eslint happy
+/* globals before */
+
+before(function (done) {
+	if (process.argv.find((_) => _ === '--dev_secrets') !== undefined) {
+		this.timeout(7000);
+		const devSecrets = require('@datanerd/codestream-utils');
+		devSecrets
+			.readVaultSecrets()
+			.then((secretsEnv) => {
+				console.log('Merging secrets...');
+				Object.assign(process.env, secretsEnv);
+				done();
+			})
+			.catch((e) => {
+				console.error('Error reading secrets', e.message);
+				done(e);
+			});
+	} else {
+		done();
+	}
+});
+
 require('./lib/test.js');
 require('../shared/server_utils/test.js');
 require('../shared/codestream_configs/test.js');

start-api-server.sh

@@ -32,7 +32,6 @@ AWS access will use codestream-server/base/ keys from vault
 "
 
 echo "$*" | grep -q '\-mock-mode' && {
-	echo "======= Mocky ======="
 	export CS_API_MOCK_MODE=1
 }
 

testMode.sh

@@ -7,16 +7,10 @@ function dev_settings {
     done
 }
 
-function dev_secrets {
-    $SCRIPT_DIR/api_server/bin/cs_dev_secrets.js
-}
-
 SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
 export CSSVC_BACKEND_ROOT=$SCRIPT_DIR
 export NODE_PATH="$CSSVC_BACKEND_ROOT/api_server/node_modules:$CSSVC_BACKEND_ROOT/broadcaster/node_modules"
-eval `dev_settings` # Needed for dev_secrets to work
-# dev_settings
-eval `dev_secrets`
+eval `dev_settings`
 export CS_API_MOCK_MODE='1'
 export CSSVC_ENV=local
 export CSSVC_CFG_FILE="$CSSVC_BACKEND_ROOT/codestream-docker.json"