Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighting #47

Open
marrub-- opened this issue Feb 21, 2017 · 5 comments
Open

Lighting #47

marrub-- opened this issue Feb 21, 2017 · 5 comments
Assignees

Comments

@marrub--
Copy link
Contributor

This depends on geometry and spatial information much like AI, and will be hard to work out until later stages.

@marrub--
Copy link
Contributor Author

In particular I have found issues with this such as "I don't know what I'm doing" and "oh god how even", so while I want to say this should be done via user shaders, I have no idea! This is still not an issue though, and will probably not be for a while, but research must be done on this.

@DavidPH
Copy link
Contributor

DavidPH commented Sep 21, 2017

One option is to give RenderThinker and Sector a color that tints the resulting texture and let the modder figure out how to set all that up. But that's really primitive and not very good looking for certain uses.

@marrub-- marrub-- self-assigned this Sep 21, 2017
@marrub--
Copy link
Contributor Author

That's not a problem really, if you want light levels like Doom that's super easy. The issue is when you want actual shadow casting and point lights, which is what I'm focusing on here.

@Kyle873
Copy link

Kyle873 commented Sep 21, 2017

Personally, I would consider this fairly low priority at the moment, but still taken into consideration while working on rendering stuff. Ultimately I think the end result should be easy to use via scripting, like having something like a LightThinker maybe? However, how feasible this would actually end up being in terms of implementation may mean a lot more involvement would be required on the user's part, but I would imagine that lighting/processing/etc would be faster implemented in the engine itself and exposed instead of being done entirely via scripting. Maybe it would be useful to investigate how other 2D engines implement their lighting systems? Two that immediately come to mind would be Nez and Ethanon.

@marrub--
Copy link
Contributor Author

No, it would be just as fast with scripting, because it's done on the GPU, not the CPU. If you needed a point light thinker you could just use a RenderThinker and have information about it be passed to the shader somehow.

Thanks for the suggestions, I'll go peek around their source code when I'm done fixing explosions.

@marrub-- marrub-- added this to the Complex game architecture milestone Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants