Back out #74

llogiq · TeXitoi · commit 0d0ed751d223 · 2018-09-09T10:34:52.000+02:00
Removing the `#[inline(never)]` was great on my mobile skylake cpu
with its beefy caches, but bad on Isaac's poor old Penryn. So
let's back out that change again.
diff --git a/src/spectralnorm.rs b/src/spectralnorm.rs
@@ -113,6 +113,9 @@ fn dot(v: &[F64x2], u: &[F64x2]) -> f64 {
     r.sum()
 }
 
+// Hint that this function should not be inlined. Keep the parallelised code tight, and vectorize
+// better.
+#[inline(never)]
 fn div_and_add(x: F64x2,
                a0: F64x2,
                a1: F64x2,

Original file line number	Diff line number	Diff line change
`@@ -113,6 +113,9 @@ fn dot(v: &[F64x2], u: &[F64x2]) -> f64 {`
`113`	`113`	`r.sum()`
`114`	`114`	`}`
`115`	`115`
	`116`	`+// Hint that this function should not be inlined. Keep the parallelised code tight, and vectorize`
	`117`	`+// better.`
	`118`	`+#[inline(never)]`
`116`	`119`	`fn div_and_add(x: F64x2,`
`117`	`120`	`a0: F64x2,`
`118`	`121`	`a1: F64x2,`