Skip to content

Commit 83a06f6

Browse files
committed
1. Added support of MSIE JavaScript Engine version 1.7.0 Alpha 2;
2. In configuration settings was added one new property - `EnableDebugging` (default `false`).
1 parent 39556cf commit 83a06f6

File tree

6 files changed

+21
-3
lines changed

6 files changed

+21
-3
lines changed

src/JavaScriptEngineSwitcher.Msie/Configuration/MsieConfiguration.cs

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,17 @@
77
/// </summary>
88
public sealed class MsieConfiguration : ConfigurationSection
99
{
10+
/// <summary>
11+
/// Gets or sets a flag for whether to enable script debugging features
12+
/// (only works in the <code>ChakraIeJsRt</code> and <code>ChakraEdgeJsRt</code> modes)
13+
/// </summary>
14+
[ConfigurationProperty("enableDebugging", DefaultValue = false)]
15+
public bool EnableDebugging
16+
{
17+
get { return (bool)this["enableDebugging"]; }
18+
set { this["enableDebugging"] = value; }
19+
}
20+
1021
/// <summary>
1122
/// Gets or sets a JavaScript engine mode
1223
/// </summary>

src/JavaScriptEngineSwitcher.Msie/JavaScriptEngineSwitcher.Msie.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
</ItemGroup>
4747
<ItemGroup>
4848
<Reference Include="MsieJavaScriptEngine, Version=1.7.0.0, Culture=neutral, PublicKeyToken=a3a2846a37ac0d3e, processorArchitecture=MSIL">
49-
<HintPath>..\..\packages\MsieJavaScriptEngine.1.7.0-alpha1\lib\net40\MsieJavaScriptEngine.dll</HintPath>
49+
<HintPath>..\..\packages\MsieJavaScriptEngine.1.7.0-alpha2\lib\net40\MsieJavaScriptEngine.dll</HintPath>
5050
<Private>True</Private>
5151
</Reference>
5252
<Reference Include="System" />

src/JavaScriptEngineSwitcher.Msie/MsieJsEngine.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ public MsieJsEngine(MsieConfiguration config)
7272
{
7373
_jsEngine = new OriginalJsEngine(new OriginalJsEngineSettings
7474
{
75+
EnableDebugging = msieConfig.EnableDebugging,
7576
EngineMode = Utils.GetEnumFromOtherEnum<JsEngineMode, OriginalJsEngineMode>(
7677
msieConfig.EngineMode),
7778
UseEcmaScript5Polyfill = msieConfig.UseEcmaScript5Polyfill,
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<packages>
3-
<package id="MsieJavaScriptEngine" version="1.7.0-alpha1" targetFramework="net40-Client" />
3+
<package id="MsieJavaScriptEngine" version="1.7.0-alpha2" targetFramework="net40-Client" />
44
</packages>

test/JavaScriptEngineSwitcher.Tests/App.config

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@
2929
type="JavaScriptEngineSwitcher.ChakraCore.ChakraCoreJsEngine, JavaScriptEngineSwitcher.ChakraCore" />
3030
</engines>
3131
</core>
32-
<msie engineMode="Auto" useEcmaScript5Polyfill="true" useJson2Library="true" />
32+
<msie enableDebugging="false" engineMode="Auto"
33+
useEcmaScript5Polyfill="true" useJson2Library="true" />
3334
<v8 enableDebugging="false" debugPort="9222" disableGlobalMembers="false"
3435
maxNewSpaceSize="0" maxOldSpaceSize="0" maxExecutableSize="0" />
3536
<jurassic enableDebugging="false" enableIlAnalysis="false"

test/JavaScriptEngineSwitcher.Tests/JavaScriptEngineSwitcher.Configuration.xsd

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,11 @@
9595
<xs:annotation>
9696
<xs:documentation>Configuration settings of MSIE JavaScript engine</xs:documentation>
9797
</xs:annotation>
98+
<xs:attribute name="enableDebugging" type="Boolean_SchemaType" use="optional" default="false">
99+
<xs:annotation>
100+
<xs:documentation>Flag for whether to enable script debugging features (only works in the `ChakraIeJsRt` and `ChakraEdgeJsRt` modes)</xs:documentation>
101+
</xs:annotation>
102+
</xs:attribute>
98103
<xs:attribute name="engineMode" use="optional" default="Auto">
99104
<xs:annotation>
100105
<xs:documentation>JavaScript engine mode</xs:documentation>

0 commit comments

Comments
 (0)