Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing type STRINGS when parsing attributes #40

Open
q-ycong-p opened this issue Jan 26, 2022 · 1 comment
Open

Missing type STRINGS when parsing attributes #40

q-ycong-p opened this issue Jan 26, 2022 · 1 comment

Comments

@q-ycong-p
Copy link

The current implementation doesn't support STRINGS as attribute type. Per ONNX sepc for LSTM, one of the attributes can be activations which is of type STRINGS. This leads to conversion error on LSTM models. Could you add STRINGS attribute type?

@q-ycong-p
Copy link
Author

Hi @calvinmccarter-at-lightmatter and @Talmaj ,

As a follow-up to the original request, I understand that STRINGS attrib being missing might be related to the fact that activation attribute is not current supported (refers here). If possible, can we please add support for explicitly listed torch-compatible activations? Since some 3p-converter-generated onnx models by default specify the activation fields (e.g. ['Sigmoid','Tanh','Tanh'] for LSTM).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant