Skip to content

Commit

Permalink
chore(CI): Revert nightly AppImage name to "nightly"
Browse files Browse the repository at this point in the history
Changed in 41a555d, I think by accident.
Causes our release uploader to no longer replace the old version, instead
adding a new version each time it runs.

Keeping named overwrite instead of removing release artifacts and
uploading new ones, since removing old artifacts would require a new job
that all other jobs depend on to avoid re-removing, and would also
create a gap while CI is running run where no artifact is available.

We could upload artifacts using actions/upload-artifact in each job then
download them at the end and update the release at that point too, if we
really want to keep sha name in the nightly release artifacts. I don't
see much value of having the sha in the filename though.
  • Loading branch information
anthonybilinski committed Feb 24, 2022
1 parent d3995bc commit b24610f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build-test-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ jobs:
prerelease: true
replacesArtifacts: true
token: ${{ secrets.GITHUB_TOKEN }}
artifacts: "qTox-*.x86_64.AppImage,qTox-*.x86_64.AppImage.zsync"
artifacts: "qTox-nightly.x86_64.AppImage,qTox-nightly.x86_64.AppImage.zsync"
build-flatpak:
name: Flatpak
runs-on: ubuntu-latest
Expand Down

0 comments on commit b24610f

Please sign in to comment.