Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken external image links #66

Open
jwhaney opened this issue Jun 14, 2019 · 6 comments
Open

broken external image links #66

jwhaney opened this issue Jun 14, 2019 · 6 comments

Comments

@jwhaney
Copy link
Contributor

jwhaney commented Jun 14, 2019

seems like there are a few images in some lakes' story content that have external images. some of these external image urls no longer exist or have been moved as you can see in the below screen shots.

Screenshot from 2019-06-14 09-54-16

Screenshot from 2019-06-14 09-54-43

we probably just need to spend some time going through all the stories and replacing any broken external image resources with local (ie. upload to s3) images.

@jwhaney
Copy link
Contributor Author

jwhaney commented Sep 5, 2019

@jwhaney
Copy link
Contributor Author

jwhaney commented Sep 5, 2019

@jwhaney
Copy link
Contributor Author

jwhaney commented Sep 5, 2019

@jwhaney
Copy link
Contributor Author

jwhaney commented Sep 5, 2019

@jwhaney
Copy link
Contributor Author

jwhaney commented Sep 5, 2019

I'm bumping this up to a Tier 1 issue because I think all of these external broken images should be fixed before this app goes public.

My suggestion would be to find images that you want to use @LaurenKirk & @csidenblad, download them and then upload them to the lake-gallery S3 bucket in the admin console. Then use that url for the story content. The problem with using external urls is exactly what we are experiencing here. Devs and other people change their apps and paths, etc, and then that change breaks our references to their content/resources. Let's just make it our resource and we won't have that problem. Just a thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants