Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB username, password and DB name disclosed publicly #33

Open
Farhan-16 opened this issue Apr 3, 2020 · 3 comments
Open

DB username, password and DB name disclosed publicly #33

Farhan-16 opened this issue Apr 3, 2020 · 3 comments

Comments

@Farhan-16
Copy link

Hi,

Below URL is disclosing the DB username, password and DB name,
https://github.com/TIBCOSoftware/js-docker/blob/master/kubernetes/helm/values.yaml

This doesn't seem like the best possible practice.

Thank you
Farhan Patil

@ericjohnson-tibco
Copy link

Indeed - perhaps we can comment out the username, password, and DB name, so that customers are forced to enter their own versions, rather than accidentally using the defaults that we've provided?

@sgwood63
Copy link
Contributor

sgwood63 commented Apr 3, 2020 via email

@ysavoche
Copy link

this issue is resolved in the v8.0.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants