Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reason for 49 frames (extra split for interpolation) #659

Open
2 tasks
karan-dalal opened this issue Jan 12, 2025 · 4 comments
Open
2 tasks

Reason for 49 frames (extra split for interpolation) #659

karan-dalal opened this issue Jan 12, 2025 · 4 comments
Assignees

Comments

@karan-dalal
Copy link

System Info / 系統信息

N/A

Information / 问题信息

  • The official example scripts / 官方的示例脚本
  • My own modified scripts / 我自己修改的脚本和任务

Reproduction / 复现过程

N/A

Expected behavior / 期待表现

I am finetuning the T2V model, and wanted to understand why we are required to have 4x+1 frame count.

I see that the DownSample3D module in the VAE will split the first frame off, and only interpolate the remaining frames.

if get_context_parallel_rank() == 0 and fake_cp:

Why do we not set frames to 48, why do we need a frame that doesn't interpolate with others?

@yzy-thu
Copy link
Contributor

yzy-thu commented Jan 14, 2025

We follow magvit-v2 (https://arxiv.org/html/2310.05737v2). 4x+1 enable joint training with images and videos

@karan-dalal
Copy link
Author

If I'm only finetuning with videos, would it be better to just train without the extra 1?

@zhuochen02
Copy link

same question

1 similar comment
@Wang-pengfei
Copy link

same question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants