JQuery in guidelines.xsl (and many other places)

[martindholmes]

For a long time now I've been getting regular warnings by email from the GitHub Dependabot tool warning that teic.github.io has an ancient vulnerable version of JQuery (jquery-1.2.6.min.js) which should be updated to 1.6.3 or higher. Looking through the TEI and Stylesheets repos, I find dozens of references to various versions of JQuery, none of which are up to date. I think it's time to try to purge all dependencies on JQuery and replace them with simple modern vanilla CSS and JS.

[joeytakeda]

Very much agreed. In the Stylesheets repo, JQuery is included in guidelines.xsl (as @martindholmes says):

Stylesheets/odds/guidelines.xsl

Lines 659 to 679 in a394b17

	<xsl:template name="javascriptHook">
	<script type="text/javascript" src="jquery-1.2.6.min.js">
	<xsl:comment>JQuery</xsl:comment>
	</script>
	<script type="text/javascript" src="columnlist.js">
	<xsl:comment>JQuery columnlist</xsl:comment>
	</script>
	<script type="text/javascript">
	$(function() {
	$('ul.attrefs-class').columnizeList({cols:3,width:30,unit:'%'});
	$('ul.attrefs-element').columnizeList({cols:3,width:30,unit:'%'});
	$(".displayRelaxButton").click(function() {
	$(this).parent().find('.RNG_XML').toggle();
	$(this).parent().find('.RNG_Compact').toggle();
	});
	$(".tocTree .showhide").click(function() {
	$(this).find(".tocShow,.tocHide").toggle();
	$(this).parent().find("ul.continuedtoc").toggle();
	});
	})
	</script>

Which I believe is generated by TEI/P5/Utilities/guidelines.xsl.model ?

https://github.com/TEIC/TEI/blob/dev/P5/Utilities/guidelines.xsl.model#L638-L672

columnlist.js (which is in TEIC/TEI/P5/webnav/columnlist.js) could be, I think, simply replaced with CSS columns or with grid

ul {
 column-count: 3
}

/* Or */

ul {
display:grid;
grid-template-columns: repeat(1fr, 3)
}

[martindholmes]

I'd be inclined to do something like:

ul{
  columns: 14em auto;
  column-gap: 2rem;
}

which would give flexibility for small-format devices.

Dependabot alerts can be seen here:

https://github.com/TEIC/teic.github.io/security/dependabot

[sydb]

Assigning to @joeytakeda to take a crack in a branch and report back (or submit PR if all went smoothly … but I have my suspicions :-).

[joeytakeda]

Not sure if this is resolved with the recent release and @raffazizzi 's fix (c.f. TEIC/TEI#2657)

[raffazizzi]

@joeytakeda I removed the dependency for the TEI Guidelines, but that was injected by an XSLT in the TEI repo. I think the Stylesheets still include JQuery deps in other conversions. I can see it in epub, for example.