-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compatibility of identifiers with BIGG database #172
Comments
@snmendoz thanks for opening this issue! Including BIGG ids would for sure be a great contribution, and if you already have some work on it, even better. See if you can complement your matching with the recently included metaNetX ids we added for rxns and mets in #167.
I would say that would be the best for now; you could even add that conversion as an option in
I would suggest just leaving the current rxn/met id if there is no match to BIGG. Perhaps remove the first
Maybe we can look into this later depending on how often it happens. In case of doubt, the solution of leaving the previous id could also be used. As a final thought, note that if you add said dictionary to the repo and the coverage is good, we could 1) implement a conversion also for Looking forward then to your dictionary! :) |
@BenjaSanchez would you please assign this task to me to avoid duplicated efforts?. I am almost done with the translation to BIGG identifiers :) |
Hi @BenjaSanchez @hongzhonglu @feiranl I will summarize here what I did to get your approval regarding the modifications I did to the model. I would appreciate your feedback. As soon as I get your approval I will make a pull request. Otherwise, I am happy to make corrections according to your suggestions.
In general terms, I created a script to make the dictionary and another to transform the model from the current identifiers to BiGG, and vice-versa. This is a group contribution. Contributions are listed according to the CRedit Taxonomy: |
@snmendoz very nice work! One comment here, |
@hongzhonglu sorry. What I meant was that the new BiGG identifiers (for those metabolites which do not have a translation to the BiGG database) were not included in the model. The metabolites in the model are the same than always. |
Description of the issue:
Dear all,
I would like to use yeast-GEM as a template for reconstructing other yeast metabolic networks. For example, I could use RAVEN, AuReMe or MetaDraft to create draft models for my yeast from yeast-GEM.
The problem is that If I would want to use other templates in addition to yeast-GEM (for example, models from the BIGG database) the automatic merge of the output draft networks (from each template) wouldn't be possible because of identifiers incompatibility.
For me, it would be of great help if the model would be written with BIGG identifiers but I can imagine a series of problems:
@BenjaSanchez already mentioned two additional problems
Backward compatibility: People is already using the model as it is so new identifiers would mean that their current code won't work anymore.
Possible solution: I could make a script with a dictionary, so people could convert one format to another with this script
Missing IDs: what should we do with identifiers that are not in the BIGG database?
Possible solution: create new identifiers in a systematic and automatic way.
What do you think? I already have some scripts to change identifiers, so I think it wouldn't be so problematic for me to make this change. If I change the identifiers, would be worth it for other people too?
I hereby confirm that I have:
master
branch of the repositoryThe text was updated successfully, but these errors were encountered: