-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata in plaintext exports #71
Comments
@mihai-sysbio please clarify the issue by providing more explanations, and maybe examples. If this issue is to adjust/modify the spec or content of |
How about something like this: !!omap
- name: "official name"
- version: "x.x.x"
- authors: "author1, author2"
- description: "one line description"
- source: "github url" This information doesn't seem to be part of the model files regardless of the format, so even if RAVEN would be able to export this as metadata, it wouldn't know where to get it from. |
Point taken! |
It appears this topic is more relevant to RAVEN (or COBRApy), where would be more appropriate for such discussion/question. |
One thing should be noted is the |
@mihai-sysbio jus got a second thought about this: tailored |
@pecholleyc how about we start with a hand-crafted |
Updated content of the metadata: - metadata:
id : "HumanGEM"
short_name : "human"
full_name : "Human metabolic model v1"
description: "1-3 lines description"
version : "1.0.0"
author:
- first_name : "fn"
last_name : "ln"
email : "email"
organization: "org"
- first_name : "fn2"
last_name : "ln2"
email : "email2"
organization: "org2"
date : "YYYY-MM-DD"
sample : "tissue, cell line, cell type, organ etc.."
condition : "Generic metabolism"
pmid : (optional)
- "PMID1"
- "PMID2"
github : "https://github.com/SysBioChalmers/human-GEM" This section should be added in the very beginning of the file, on top of "metabolites". |
@pecholleyc regarding the proposed spec for metadata, I suggest to remove the following information: |
@Hao-Chalmers all the fields you mentioned are required by Metabolic Atlas. |
Let me clarify why these information should be in the YAML:
I was thinking also adding information such as species, taxonomy and organism. Fields that are commonly found in the SBML format. Note: I hope one day, some of this content will be available on Metabolic Atlas documentation in a section called something like "Import your own model". |
@pecholleyc I'm a bit confusing, how could something be both required and optional? I feel like the inclusion of metadata wouldn't be done at once, shall we just start with the certain ones? |
@Hao-Chalmers All of the fields are required, except the ones that @pecholleyc specifically states are optional ( |
This update is implemented by running script `miscModelCurationScript_20190323.m`: - metadata is incoporated both in mat and yaml files according to #71 - reformat EC-number in `eccodes` field, as discussed in #93 - remove `rxnComps` field, according to #184 in RAVEN - empty `version` field to enable a simple and clear work flow - initialize `rxnConfidenceScores` field with zero, as discussed in #48
This issue had been well resolved in #95, and thus closed. |
The plaintext model files (e.g.
yaml
) should include metadata. This should be at least the version number, but it could also be a list of authors, a url, and a short description.The text was updated successfully, but these errors were encountered: