New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] A github action to check packages can be replaced on pr #47

Open

fengkx opened this issue Nov 14, 2023 · 0 comments

Contributor

fengkx commented Nov 14, 2023

I want to check for new packages to replace on pr using github action.

One approch is using JavaScript action.
The main field in package.json is now a invalid path, But the packages list can be obtained by

import nolyfill from "nolyfill/dist/index.js";
// ....
const packagesCoveredByNolyfill = await nolyfill.findPackagesCoveredByNolyfill(packageManager, projectPath);

But JavaScript action need to be bundled, once nolyfill is bundled, new nolyfill version will not be updated unless the JavaScript action is updated.

Another approch is runing cli in shell. Maybe a json output mode is needed.

fengkx mentioned this issue

feat: add json output mode for check command #50

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment