start_sublime_text helper

[rchl]

There is this start_sublime_text that starts sublime:

UnitTesting/sbin/run_tests.py

Line 99 in ecf6add

subprocess.Popen("subl &", shell=True)

1. Why does it use &? I understand that this means "run command in the background" but is it really relevant here? It seems to work just fine.
2. On opening, a /tmp/ file is opened in a tab. Can this be avoided? I don't exactly see the point of it. I guess this is something related to subprocess but I don't exactly understand why it happens.
3. I think this could be improved by passing --stay argument as otherwise, once the tab this command opens is closed, focus switches back to the terminal which can (and does) affect some focus specific tests

[randy3k]

1. It was the original comment for the &. I don't know if it is still needed.

        # In some Linux/macOS CI environments, starting ST simply with `subl`
        # causes the CI process to time out. Using `subl &` seems to solve
        # this.

2. I remember that there was a problem of subl and I vaguely recall that it has been fixed in Sublime Text 4.
3. @rwols is actually working on a refactoring, perhaps you could give your 2 cents there: WIP: Asyncio in run tests script #179

[rchl]

2. That seems to happen only when using & in the command so removing it would solve both 1 and 2.
   But then I suppose we can't do much if we don't know a specific reason why it's here.

[rchl]

@FichteFoll made a comment on Discord that makes it clear:

note that ST3's subl used to stick around if it there was no existing sublime process running already. the behavior of always starting and communicating with a background process is new in ST4 afaict

And indeed it blocks if ST3 is not yet started

[rchl]

@rwols would you like to handle 3) on your branch or separately? I think --stay should actually help with LSP tests so it would be perfect if we could get that change separately ASAP.

[rwols]

Well, my PR is somewhat larger than that change.
I think it's best if it were a separate PR, my PR might take a while as I have to modify Windows, macOS and docker dependent files.

[randy3k]

#181 has closed it.