Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

Commit 08a1f06

Browse files
pnunes30Matthieu Saignemorte
authored andcommitted
netdev_driver: get/set power with signed values
1 parent 5fa8b7a commit 08a1f06

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

stack/framework/hal/chips/netdev_driver/inc/sx127x.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ typedef struct {
209209
typedef struct {
210210
uint16_t preamble_len; /**< Length of preamble header */
211211
uint8_t sync_len; /**< Length of sync word */
212-
uint8_t power; /**< Signal power */
212+
int8_t power; /**< Signal power */
213213
uint8_t bandwidth; /**< Signal bandwidth */
214214
uint8_t datarate; /**< bitrate in bps */
215215

@@ -662,7 +662,7 @@ void sx127x_set_payload_length(sx127x_t *dev, uint16_t len);
662662
*
663663
* @return the radio power
664664
*/
665-
uint8_t sx127x_get_tx_power(const sx127x_t *dev);
665+
int8_t sx127x_get_tx_power(const sx127x_t *dev);
666666

667667
/**
668668
* @brief Sets the SX127X transmission power

stack/framework/hal/chips/netdev_driver/sx127x_getset.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1051,7 +1051,7 @@ static inline uint8_t sx127x_get_pa_select(const sx127x_t *dev)
10511051
return SX127X_RF_PACONFIG_PASELECT_RFO;
10521052
}
10531053

1054-
uint8_t sx127x_get_tx_power(const sx127x_t *dev)
1054+
int8_t sx127x_get_tx_power(const sx127x_t *dev)
10551055
{
10561056
switch (dev->settings.modem) {
10571057
case SX127X_MODEM_FSK:

stack/framework/hal/chips/netdev_driver/sx127x_netdev.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -475,8 +475,8 @@ static int _get(netdev_t *netdev, netopt_t opt, void *val, size_t max_len)
475475
return sizeof(netopt_enable_t);
476476

477477
case NETOPT_TX_POWER:
478-
assert(max_len >= sizeof(int16_t));
479-
*((int16_t*) val) = (int16_t)sx127x_get_tx_power(dev);
478+
assert(max_len >= sizeof(int8_t));
479+
*((int8_t*) val) = sx127x_get_tx_power(dev);
480480
return sizeof(int16_t);
481481

482482
case NETOPT_IQ_INVERT:
@@ -671,8 +671,8 @@ static int _set(netdev_t *netdev, netopt_t opt, const void *val, size_t len)
671671
res = -EINVAL;
672672
break;
673673
}
674-
sx127x_set_tx_power(dev, (int8_t)power);
675-
return sizeof(int16_t);
674+
sx127x_set_tx_power(dev, power);
675+
return sizeof(int8_t);
676676

677677
case NETOPT_FIXED_HEADER:
678678
assert(len <= sizeof(netopt_enable_t));

0 commit comments

Comments
 (0)