sqlite: add userVersion concurrency test

Author: wmertens

package-lock.json

@@ -45,7 +45,7 @@
     "uuid": ">=8 <10"
   },
   "devDependencies": {
-    "prettier-plugin-jsdoc": "^1.3.0",
+    "@types/node": "^22.10.7",
     "@typescript-eslint/eslint-plugin": "^7.16.0",
     "@typescript-eslint/parser": "^7.16.0",
     "@vitest/coverage-v8": "2.0.2",
@@ -60,6 +60,7 @@
     "fs-extra": "^11.2.0",
     "nps-utils": "^1.7.0",
     "prettier": "^3.3.3",
+    "prettier-plugin-jsdoc": "^1.3.0",
     "tmp-promise": "3.0.3",
     "typescript": "^5.5.3",
     "vite": "^5.3.3",

package.json

@@ -1,4 +1,4 @@
-import sysPath from 'path'
+import sysPath from 'node:path'
 import tmp from 'tmp-promise'
 import SQLite, {sql, valToSql} from './SQLite'
 
@@ -108,7 +108,7 @@ describe('SQLite', () => {
 					await extraDb.exec('UPDATE t SET v=v+1 WHERE id=1')
 					await extraDb.close()
 				}
-				const Ps = []
+				const Ps: Promise<void>[] = []
 				for (let i = 0; i < 10; i++) {
 					Ps.push(openClose())
 				}
@@ -319,13 +319,51 @@ describe('SQLite', () => {
 		await expect(db.userVersion()).resolves.toBe(5)
 	})
 
+	test.only('concurrent userVersion()', async () => {
+		const dir = await tmp.dir({unsafeCleanup: true, prefix: 'sqlite-test-'})
+		const {path} = dir
+		const file = sysPath.join(path, 'db')
+		const db1 = new SQLite({file})
+		const db2 = new SQLite({file})
+		try {
+			const p1 = db1.userVersion()
+			const p2 = db2.userVersion()
+			expect(await Promise.all([p1, p2])).toEqual([0, 0])
+			await db1.userVersion(5)
+			expect(await Promise.all([db1.userVersion(), db2.userVersion()])).toEqual(
+				[5, 5]
+			)
+
+			let writer, waiter
+			const writerP = new Promise(r => (writer = r))
+			const waiterP = new Promise(r => (waiter = r))
+
+			const db1Done = db1.__withTransaction(async () => {
+				await db1.userVersion(10)
+				writer()
+				await waiterP
+			})
+
+			await writerP
+			expect(await db1.userVersion()).toBe(10)
+			expect(await db2.userVersion()).toBe(5)
+			waiter!()
+			await db1Done
+			expect(await db2.userVersion()).toBe(10)
+		} finally {
+			await db1.close()
+			await db2.close()
+			await dir.cleanup()
+		}
+	})
+
 	test('.each()', async () => {
 		const db = new SQLite()
 		await db.exec(
 			`CREATE TABLE foo(hi NUMBER); INSERT INTO foo VALUES (42),(43);`
 		)
 		for (let i = 0; i < 100; i++) await db.run('INSERT INTO FOO VALUES(?)', i)
-		const arr = []
+		const arr: number[] = []
 		let flag = false
 		await db.each(`SELECT * FROM foo`, ({hi}) => {
 			// it should wait until db.each is done

src/DB/SQLite.test.js src/DB/SQLite.test.ts

@@ -10,7 +10,7 @@
 
 		// Available types
 		"lib": ["ES2021"],
-		"types": ["vite/client", "vitest/globals"],
+		"types": ["vite/client", "vitest/globals", "node"],
 
 		// Module resolution
 		"forceConsistentCasingInFileNames": true,