Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spidyan/saffron: review #148

Open
5 tasks
spribitzer opened this issue Oct 23, 2019 · 2 comments
Open
5 tasks

spidyan/saffron: review #148

spribitzer opened this issue Oct 23, 2019 · 2 comments
Assignees
Labels
major Something that requires major work

Comments

@spribitzer
Copy link
Contributor

spribitzer commented Oct 23, 2019

Before going open source with EasySpin 6.0, the time propagation engine needs to be reviewed and a few things need to be addressed:

@spribitzer spribitzer added this to the 6.0 milestone Oct 23, 2019
@spribitzer
Copy link
Contributor Author

there is potential in s_thyme to make code more modular:

  • propagation step
  • storing of the detected signal

@spribitzer
Copy link
Contributor Author

There is an undocumented feature which allows the user to directly input an IQ (instead of defining pulse parameters). This part of the code needs to be cleaned up and made more modular.

Though it might be useful for some (really advanced) users, it would confuse pulse shaping beginners . If we decide to add this feature to the documentation, we have to be very careful about how and where.

@spribitzer spribitzer added the major Something that requires major work label Feb 26, 2020
@spribitzer spribitzer changed the title spidyan/saffron: review before going open source spidyan/saffron: review Feb 26, 2020
@stestoll stestoll removed this from the 6.0 milestone Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Something that requires major work
Development

No branches or pull requests

2 participants