Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spidyan/saffron: add controls for the integration time and the data points that are recorded for detecting #126

Open
stestoll opened this issue Dec 22, 2018 · 1 comment
Open

spidyan/saffron: add controls for the integration time and the data points that are recorded for detecting #126

stestoll opened this issue Dec 22, 2018 · 1 comment
Assignees
@spribitzer
Labels
major Something that requires major work proposal A new idea

Comments

@stestoll
Copy link
Member

Original report by Stephan Pribitzer (Bitbucket: 557058:b436f856-3789-41af-afc1-0e3566ff0302, ).

Proposal:

Opt.IntTimeStep: 30 times Nyquist

Exp.DetTimeStep: 2 times Nyquist

  • nothing given - by default the programs assumes default values
  • both are given - if Exp.DetTimeStep is not a multiple of Opt.IntTimeStep, an error is returned
  • only Exp.DetTimeStep is given - Opt.IntTimeStep is adapted by shortening
  • Opt.IntTimeStep is given - use Nyquist criterion to compute Exp.DetTimeStep
@stestoll
Copy link
Member Author

Original comment by Stephan Pribitzer (Bitbucket: 557058:b436f856-3789-41af-afc1-0e3566ff0302, ).

with commit #256a686 the time axis is now created correctly. tests were added.

however, a new problem arises during down conversion. if the detection time step is not the integration time step, oscillations are not completely removed - the source of this needs to be investigated

@stestoll stestoll added major Something that requires major work proposal A new idea labels Sep 18, 2019
@stestoll stestoll added this to the 6.0 milestone Sep 18, 2019
@spribitzer spribitzer self-assigned this Mar 16, 2020
@stestoll stestoll removed this from the 6.0 milestone Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spribitzer spribitzer

Labels
major Something that requires major work proposal A new idea
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stestoll @spribitzer