Move service declaration to PHP

Author: pocky

README.md

@@ -10,7 +10,8 @@
 
 ## Warning
 
-This plugin DO NOT follow standard Sylius directory structure for plugins but a new "Symfony standard skeleton" one.
+This plugin DO NOT follow standard Sylius directory structure for plugins but a new "Symfony standard skeleton" one
+and services declaration in PHP (Symfony is actually leaving xml for PHP).
 
 New directory structure:
 

config/services.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symfony\Component\DependencyInjection\Loader\Configurator;
+
+return static function (ContainerConfigurator $configurator) {
+    $configurator->import('services/*');
+};

config/services.xml

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symfony\Component\DependencyInjection\Loader\Configurator;
+
+use Acme\SyliusExamplePlugin\Controller\GreetingController;
+
+return function (ContainerConfigurator $configurator) {
+    $services = $configurator->services();
+
+    $services->set(GreetingController::class)
+        ->autowire()
+        ->autoconfigure()
+        ->public();
+};

config/services/controller.php

@@ -8,16 +8,17 @@
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Extension\Extension;
-use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
+use Symfony\Component\DependencyInjection\Loader\FileLoader;
+use Symfony\Component\DependencyInjection\Loader\PhpFileLoader;
 
 final class AcmeSyliusExampleExtension extends Extension
 {
     public function load(array $configs, ContainerBuilder $container): void
     {
         $config = $this->processConfiguration($this->getConfiguration([], $container), $configs);
-        $loader = new XmlFileLoader($container, new FileLocator(__DIR__ . '/../../config'));
+        $loader = new PhpFileLoader($container, new FileLocator(__DIR__ . '/../../config'));
 
-        $loader->load('services.xml');
+        $loader->load('services.php');
     }
 
     public function getConfiguration(array $config, ContainerBuilder $container): ConfigurationInterface