Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unclear warning StoxBiotic #267

Open
edvinf opened this issue Dec 12, 2022 · 3 comments
Open

unclear warning StoxBiotic #267

edvinf opened this issue Dec 12, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@edvinf
Copy link
Contributor

edvinf commented Dec 12, 2022

When converting to StoxBiotic a warning is issued if there are several serialnumbers for a station i NMDbiotic:

"There are more than one 'serialnumber' (HaulKey in StoxBioticData) for 113 out of 243 'station'(StationKey in StoxBioticData) in the NMDBiotic data. In DefineBioticAssignment() it is currently only possible to asssing all hauls of a station in the map (manual assignment). If certain Hauls should be exclcuded, use FilterStoxBiotic(). Duplicated serialnumber for the following cruise/station (of the fishstation table of the BioticData):
<...list of cruise / station ids>"

The last line in the warning refers to duplicated serialnumbers, which makes it sound like serialnumbers are not unique in the source data. Should probably say "Several serialnumbers for the following ..."

Secondly, the error message refers to cruise/station as if these are fields in the fishstationtable of BioticData. That is true for 'station', but 'cruise' is a field on the table 'mission' in NMDbiotic.

There is also a typo: 'asssing' --> 'assigning' ?

@BergenCalling

This comment was marked as resolved.

@edvinf
Copy link
Contributor Author

edvinf commented Jan 20, 2023

The warning message also oddly lists a unique cruise/station numbers where these apply, but the 'cruise'-part does not seem to be idenitfying a cruise in neither Biotic or StoxBiotic. Particularly for commercial fisheries data, the 'cruise'-variable is typically NA. First of all this makes it difficult for users to trace which stations are actually probalematic. Secondly, it may wrongly identify them altogether. Station-numbers are only supposed to be unique for a given mission in NMDbiotic.

@edvinf
Copy link
Contributor Author

edvinf commented Aug 28, 2023

I also think the reference to DefineBioticAssignment can be dropped here, since issues with incorrect use of stationnumbers also create problems for many other kinds of downstream analysis. It should be easy to check in DefineBioticAssignement if it is processing data with several hauls for any station and issue a warning there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants