Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LC0064 - False positive on page controls not using Rec. #681

Open
fvet opened this issue Jul 8, 2024 · 3 comments
Open

LC0064 - False positive on page controls not using Rec. #681

fvet opened this issue Jul 8, 2024 · 3 comments
Labels
bug Something isn't working investigate

Comments

@fvet
Copy link
Contributor

fvet commented Jul 8, 2024

I've a page based on table 'Document' (with a field "Error Rows").

LC0064 shows up for a lot of page field controls having Rec.FieldNo as source expression. Fixing those errors in batch (using code actions from AL v14.x) moves the tooltips from the page to the table, which is fine.

However, LC0064 shows up for page field controls referencing AnotherRecord.FieldNo value (AnotherRecord references the same table as the page SourceTable). If I would perform the codeaction, the tooltip is moved from the page to the (AnotherRecord) table, which seems ok. Although, when publishing a new version of the app, the page field does not longer inherit the tooltip from the (AnotherRecord) table.

Seems like inheritance of table tooltips only works for Rec variables.

image

Requested change:

  • Please only include page field controls with Rec. as value in the LC0064 rule, to avoid other tooltips no longer to be shown.

PS: Not sure if the should be logged on https://github.com/microsoft/AL to ensure either the codeaction excludes those cases and if the runtime should inherited tooltips from non Rec. values as well.

@Arthurvdv Arthurvdv added the bug Something isn't working label Jul 8, 2024
@Arthurvdv
Copy link
Collaborator

.. the page field does not longer inherit the tooltip from the (AnotherRecord) table

This is not the behavior I would expect and I'm thinking that you may have found a bug. I would suggest raising this issue on the https://github.com/microsoft/AL and depending on the response adapt the rule (if necessary).

Do you want to do the honors of creating an issue?

@fvet
Copy link
Contributor Author

fvet commented Jan 16, 2025

@Arthurvdv FYI, Issue still remains.

Logged an issue at microsoft/AL#7949

Current LC0064 false positive for the above mentioned issue.

Image

@Arthurvdv
Copy link
Collaborator

Thanks for creating the issue, where I see it’s already been accepted, which is great!

Once we have feedback on this, I’ll be happy to adjust the rule accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working investigate
Projects
None yet
Development

No branches or pull requests

2 participants