Skip to content

Commit 79c7eba

Browse files
authored
Merge pull request #906 from pradnya-orchestral/Enhancement_error_massage
UI changes for Enhancement of Error Message
2 parents fbdc4dd + c1992e5 commit 79c7eba

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

modules/st2-action-reporter/reporters/run-local.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,17 @@ export default function runLocal(execution) {
2828
execution.result && execution.result.stderr ? [
2929
<div key="error" className={style.source}>Error</div>,
3030
<Highlight well lines={20} className={style.highlight} key="error-code" code={execution.result.stderr} type="result" id={execution.id} />,
31+
] : execution.result && execution.result.error ? [
32+
<div key="error" className={style.source}>Error</div>,
33+
<Highlight well lines={20} className={style.highlight} key="error-code" code={execution.result.error} type="result" id={execution.id} />,
3134
] : null,
3235

3336
execution.result && execution.result.traceback ? [
3437
<div key="traceback" className={style.source}>Traceback</div>,
3538
<Highlight well lines={20} className={style.highlight} key="traceback-code" code={[ execution.result.error, execution.result.traceback ].join('\n')} type="result" id={execution.id} />,
3639
] : null,
3740

38-
!execution.result || (!execution.result.stdout && !execution.result.stderr && !execution.result.traceback) ? (
41+
!execution.result || (!execution.result.stdout && !execution.result.stderr && !execution.result.error && !execution.result.traceback) ? (
3942
<Highlight well className={style.highlight} key="none" code="// Action produced no data" type="result" id={execution.id} />
4043
) : null,
4144
];

modules/st2-action-reporter/reporters/run-python.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,17 @@ export default function runPython(execution) {
3333
execution.result && execution.result.stderr ? [
3434
<div key="error" className={style.source}>Error</div>,
3535
<Highlight well lines={20} className={style.highlight} key="error-code" code={execution.result.stderr} type="result" id={execution.id} />,
36+
] : execution.result && execution.result.error ? [
37+
<div key="error" className={style.source}>Error</div>,
38+
<Highlight well lines={20} className={style.highlight} key="error-code" code={execution.result.error} type="result" id={execution.id} />,
3639
] : null,
3740

3841
execution.result && execution.result.traceback ? [
3942
<div key="traceback" className={style.source}>Traceback</div>,
4043
<Highlight well lines={20} className={style.highlight} key="traceback-code" code={[ execution.result.error, execution.result.traceback ].join('\n')} type="result" id={execution.id} />,
4144
] : null,
4245

43-
!execution.result || (!execution.result.result && !execution.result.stdout && !execution.result.stderr && !execution.result.traceback) ? (
46+
!execution.result || (!execution.result.result && !execution.result.stdout && !execution.result.stderr && !execution.result.error && !execution.result.traceback) ? (
4447
<Highlight well className={style.highlight} key="none" code="// Action produced no data" />
4548
) : null,
4649
].filter(v => v);

modules/st2-action-reporter/reporters/run-remote.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,17 @@ export default function runRemote(execution) {
3939
result && result.stderr ? [
4040
<div key="error" className={style.source}>Error</div>,
4141
<Highlight well lines={20} className={style.highlight} key="error-code" code={result.stderr} type="result" id={execution.id} />,
42+
] :result && result.error ? [
43+
<div key="error" className={style.source}>Error</div>,
44+
<Highlight well lines={20} className={style.highlight} key="error-code" code={result.error} type="result" id={execution.id} />,
4245
] : null,
4346

4447
result && result.traceback ? [
4548
<div key="traceback" className={style.source}>Traceback</div>,
4649
<Highlight well lines={20} className={style.highlight} key="traceback-code" code={[ result.error, result.traceback ].join('\n')} type="result" id={execution.id} />,
4750
] : null,
4851

49-
!result || (!result.result && !result.stderr && !result.stdout && !result.traceback) ? (
52+
!result || (!result.result && !result.stderr && !result.stdout && !result.error && !result.traceback) ? (
5053
<Highlight well className={style.highlight} key="none" code="// Action produced no data" />
5154
) : null,
5255
];

0 commit comments

Comments
 (0)