Remove new environment variable EXIT_ON_FAILURES

Remove newly created environment variable EXIT_ON_FAILURES. st2chatops should be always exit for the case if st2chatops encounters authenticate or unresolved application URL issues with Stackstorm.

Author: jinpingh

CHANGELOG.rst

@@ -8,7 +8,7 @@ in development
 -----
 * Add initial support for Microsoft Teams via BotFramework (new feature)
 * Add unit tests for all adapters (improvement)
-* Add environment variable `EXIT_ON_FAILURES` to allow `st2chatops` to exit from `st2client` failures.
+* Allow `st2chatops` to exit from `st2client` failures.
 
 0.9.2
 -----

README.md

@@ -77,7 +77,6 @@ specified when running hubot:
 * `ST2_SLACK_FAIL_COLOR` - Slack attachement color for failures either be one of good, warning, danger, or any hex color code (optional).
 * `ST2_ROCKETCHAT_SUCCESS_COLOR` - RocketChat attachement color for success, can either be one of good, warning, danger, or any hex color code (optional).
 * `ST2_ROCKETCHAT_FAIL_COLOR` - RocketChat attachement color for failures either be one of good, warning, danger, or any hex color code (optional).
-* `EXIT_ON_FAILURES` - Exit from st2chatops for st2client failures. Default is `false` (optional).
 
 Note: ``ST2_ROUTE`` environment variable mentioned below should only be
 specified if you modified the rule which comes with a ``hubot`` pack to use a

scripts/stackstorm.js

@@ -75,9 +75,6 @@ env.ST2_COMMANDS_RELOAD_INTERVAL = parseInt(env.ST2_COMMANDS_RELOAD_INTERVAL ||
 // Cap message length to a certain number of characters.
 env.ST2_MAX_MESSAGE_LENGTH = parseInt(env.ST2_MAX_MESSAGE_LENGTH || 500, 10);
 
-// Exit from st2chatops for st2client failures
-env.EXIT_ON_FAILURES = env.EXIT_ON_FAILURES || null;
-
 // Constants
 // Fun human-friendly commands. Use %s for payload output.
 var START_MESSAGES = [
@@ -173,12 +170,7 @@ module.exports = function(robot) {
       })
       .catch(function (err) {
         robot.logger.error('Failed to authenticate: ' + err.message);
-
-        if (env.EXIT_ON_FAILURES) {
-          stop({exit: true});
-        } else {
-          throw err;
-        }
+        stop({exit: true});
       });
   }
 
@@ -422,7 +414,7 @@ module.exports = function(robot) {
     });
 
     // Initial command loading
-    loadCommands({exitOnFailure: env.EXIT_ON_FAILURES});
+    loadCommands({exitOnFailure: true});
 
     // Add an interval which tries to re-load the commands
     commands_load_interval = setInterval(loadCommands.bind(), (env.ST2_COMMANDS_RELOAD_INTERVAL * 1000));
@@ -453,7 +445,7 @@ module.exports = function(robot) {
   }
 
   // Authenticate with StackStorm backend and then call start.
-  // On a failure to authenticate log the error.
+  // On a failure to authenticate log the error and quit.
   return promise.then(function () {
     start();
     return stop;