refactoring: code refactoring

Author: Nayananga

src/main/java/com/example/paul/constants/constants.java

@@ -22,5 +22,6 @@ public class constants {
 
     public static final String INVALID_TRANSACTION =
             "Account information is invalid or transaction has been denied for your protection. Please try again.";
+    public static final String CREATE_ACCOUNT_FAILED =
+            "Error happened during creating new account";
 }
-

src/main/java/com/example/paul/controllers/AccountRestController.java

@@ -26,9 +26,6 @@ public class AccountRestController {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(AccountRestController.class);
 
-    private static final String CREATE_ACCOUNT_FAILED =
-            "Error happened during creating new account";
-
     private final AccountService accountService;
 
     @Autowired
@@ -77,7 +74,7 @@ public ResponseEntity<?> createAccount(
 
             // Return the account details, or warn that no account was found for given input
             if (account == null) {
-                return new ResponseEntity<>(CREATE_ACCOUNT_FAILED, HttpStatus.OK);
+                return new ResponseEntity<>(constants.CREATE_ACCOUNT_FAILED, HttpStatus.OK);
             } else {
                 return new ResponseEntity<>(account, HttpStatus.OK);
             }

src/main/java/com/example/paul/utils/CreateAccountInput.java

@@ -1,14 +1,8 @@
 package com.example.paul.utils;
 
-import com.example.paul.constants.constants;
-import com.mifmif.common.regex.Generex;
-
 import javax.validation.constraints.NotBlank;
 import java.util.Objects;
 
-import static com.example.paul.constants.constants.ACCOUNT_NUMBER_PATTERN_STRING;
-import static com.example.paul.constants.constants.SORT_CODE_PATTERN_STRING;
-
 public class CreateAccountInput {
 
     @NotBlank(message = "Bank name is mandatory")