Support decompiling jars without mappings #187
Conversation
|
|
||
| // Extract jar | ||
| final Path extracted = this.downloader.baseDir().resolve(jarPath); | ||
| FileUtils.createDirectoriesSymlinkSafe(extracted.getParent()); |
There was a problem hiding this comment.
This should be in it's own commit/PR as this is outside scope of this PR's purpose.
There was a problem hiding this comment.
The extraction directory gets created as a result of downloading mappings
As this PR makes downloading mappings optional, we have to ensure that the target directory exists
I'll add a comment explaining this, but this is required for this PR to work
| .add(Transformers.fixLvNames()); | ||
| // apply mappings if available | ||
| mappings.ifPresent(file -> renamerBuilder | ||
| .add(Transformer.renamerFactory(file, true))); |
There was a problem hiding this comment.
This one transformer is doing the remapping but all other transformers are related to the de-obfuscation process too. When processing a non obfuscated version we should skip all transformations except access wideners, which are handled elsewhere anyway.
Actually, we could probably release the current state of VG as 0.2.1, and remove FART and all the de-obfuscation process in 0.3.0.
3 participants
Allows decompiling jars without mappings, tested with injecting 25w45a_unobfuscated.json