Skip to content

Commit 2c5dabf

Browse files
authored
Merge pull request #241 from Sparticuz/chromium/123
2 parents 8efe5f9 + c0b12ce commit 2c5dabf

File tree

8 files changed

+35
-35
lines changed

8 files changed

+35
-35
lines changed

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ test:
1414
npm install --fund=false --package-lock=false
1515
npm run build
1616
mkdir -p nodejs
17-
npm install --prefix nodejs/ [email protected] [email protected].5 --bin-links=false --fund=false --omit=optional --omit=dev --package-lock=false --save=false
17+
npm install --prefix nodejs/ [email protected] [email protected].6 --bin-links=false --fund=false --omit=optional --omit=dev --package-lock=false --save=false
1818
npm pack
1919
mkdir -p nodejs/node_modules/@sparticuz/chromium/
2020
tar --directory nodejs/node_modules/@sparticuz/chromium/ --extract --file sparticuz-chromium-*.tgz --strip-components=1

README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ const test = require("node:test");
5050
const puppeteer = require("puppeteer-core");
5151
const chromium = require("@sparticuz/chromium");
5252

53-
// Optional: If you'd like to use the new headless mode. "chrome-headless-shell" is the default.
54-
// NOTE: Because we build the chrome-headless-shell binary, this option does not work.
53+
// Optional: If you'd like to use the new headless mode. "shell" is the default.
54+
// NOTE: Because we build the shell binary, this option does not work.
5555
// However, this option will stay so when we migrate to full chromium it will work.
5656
chromium.setHeadlessMode = true;
5757

@@ -260,8 +260,8 @@ By default, this package uses `swiftshader`/`angle` to do CPU acceleration for W
260260
| `args` | `Array<string>` | Provides a list of recommended additional [Chromium flags](https://github.com/GoogleChrome/chrome-launcher/blob/master/docs/chrome-flags-for-tools.md). |
261261
| `defaultViewport` | `Object` | Returns a sensible default viewport for serverless. |
262262
| `executablePath(location?: string)` | `Promise<string>` | Returns the path the Chromium binary was extracted to. |
263-
| `setHeadlessMode` | `void` | Sets the headless mode to either `true` or `"chrome-headless-shell"` |
264-
| `headless` | `true \| "chrome-headless-shell"` | Returns `true` or `"chrome-headless-shell"` depending on what version of chrome's headless you are running |
263+
| `setHeadlessMode` | `void` | Sets the headless mode to either `true` or `"shell"` |
264+
| `headless` | `true \| "shell"` | Returns `true` or `"shell"` depending on what version of chrome's headless you are running |
265265
| `setGraphicsMode` | `void` | Sets the graphics mode to either `true` or `false` |
266266
| `graphics` | `boolean` | Returns a boolean depending on whether webgl is enabled or disabled |
267267

_/ansible/inventory.ini

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ instance_size=c6i.12xlarge
1414
ansible_connection=ssh
1515
ansible_python_interpreter=auto_silent
1616
ansible_ssh_private_key_file=ansible.pem
17-
chromium_revision=1250580
17+
chromium_revision=1262506

bin/chromium.br

-209 KB
Binary file not shown.

bin/swiftshader.tar.br

24.9 KB
Binary file not shown.

package-lock.json

+16-16
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -36,17 +36,17 @@
3636
"test": "make clean && make && make pretest && make test"
3737
},
3838
"dependencies": {
39-
"follow-redirects": "^1.15.5",
39+
"follow-redirects": "^1.15.6",
4040
"tar-fs": "^3.0.5"
4141
},
4242
"devDependencies": {
4343
"@tsconfig/node16": "^16.1.1",
4444
"@tsconfig/strictest": "^2.0.3",
4545
"@types/follow-redirects": "^1.14.4",
46-
"@types/node": "^20.11.19",
46+
"@types/node": "^20.11.30",
4747
"@types/tar-fs": "^2.0.4",
48-
"clean-modules": "^3.0.4",
49-
"typescript": "^5.3.3"
48+
"clean-modules": "^3.0.5",
49+
"typescript": "^5.4.2"
5050
},
5151
"engines": {
5252
"node": ">= 16"

source/index.ts

+9-9
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ class Chromium {
9393
* https://developer.chrome.com/articles/new-headless/#try-out-the-new-headless
9494
* @values true or "new"
9595
*/
96-
private static headlessMode: true | "chrome-headless-shell" = "chrome-headless-shell";
96+
private static headlessMode: true | "shell" = "shell";
9797

9898
/**
9999
* If true, the graphics stack and webgl is enabled,
@@ -254,7 +254,7 @@ class Chromium {
254254
];
255255

256256
const headlessFlags = [
257-
this.headless === "chrome-headless-shell" ? "--headless='chrome-headless-shell'" : "--headless",
257+
this.headless === "shell" ? "--headless='shell'" : "--headless",
258258
];
259259

260260
return [
@@ -349,29 +349,29 @@ class Chromium {
349349

350350
/**
351351
* Returns the headless mode.
352-
* "chrome-headless-shell" means the 'old' (legacy, chromium < 112) headless mode.
352+
* "shell" means the 'old' (legacy, chromium < 112) headless mode.
353353
* `true` means the 'new' headless mode.
354354
* https://developer.chrome.com/articles/new-headless/#try-out-the-new-headless
355-
* @returns true | "chrome-headless-shell"
355+
* @returns true | "shell"
356356
*/
357357
public static get headless() {
358358
return this.headlessMode;
359359
}
360360

361361
/**
362362
* Sets the headless mode.
363-
* "chrome-headless-shell" means the 'old' (legacy, chromium < 112) headless mode.
363+
* "shell" means the 'old' (legacy, chromium < 112) headless mode.
364364
* `true` means the 'new' headless mode.
365365
* https://developer.chrome.com/articles/new-headless/#try-out-the-new-headless
366-
* @default "chrome-headless-shell"
366+
* @default "shell"
367367
*/
368-
public static set setHeadlessMode(value: true | "chrome-headless-shell") {
368+
public static set setHeadlessMode(value: true | "shell") {
369369
if (
370-
(typeof value === "string" && value !== "chrome-headless-shell") ||
370+
(typeof value === "string" && value !== "shell") ||
371371
(typeof value === "boolean" && value !== true)
372372
) {
373373
throw new Error(
374-
`Headless mode must be either \`true\` or 'chrome-headless-shell', you entered '${value}'`
374+
`Headless mode must be either \`true\` or 'shell', you entered '${value}'`
375375
);
376376
}
377377
this.headlessMode = value;

0 commit comments

Comments
 (0)