Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full blast hotkey ? #22

Open
2 of 3 tasks
grimy400 opened this issue Oct 17, 2024 · 12 comments
Open
2 of 3 tasks

Full blast hotkey ? #22

grimy400 opened this issue Oct 17, 2024 · 12 comments
Assignees
Labels
type: enhancement New feature or request

Comments

@grimy400
Copy link

grimy400 commented Oct 17, 2024

Prerequisites

  • I am using the correct issue template, i.e. I am requesting a feature be added to YAMDCC. Bug reports and questions should be opened using their respective templates.
  • I have searched the issue tracker for duplicate or similar feature requests. Your issue will be closed if it is a duplicate of another issue.
  • I have not answered truthfully to the above questions.

Feature request

Is there a way to add a hotkey to enable and disable full blast would be very useful as I use my laptop closed with a monitor.

@grimy400 grimy400 added status: needs triage This issue is awaiting a triage type: enhancement New feature or request labels Oct 17, 2024
@Sparronator9999
Copy link
Owner

Woah, someone using the issue templates? Impossible!

In all seriousness though, this should be possible.

I will add it to the upcoming feature list.

@grimy400
Copy link
Author

haha ! Sounds good thanks for the quick response this program actually saved my msi laptop lol I wasnt able to use cooler booster at all anymore

@Sparronator9999
Copy link
Owner

Would you mind sharing your MSI laptop model so I can add it to the list of community-tested laptops? (e.g. my laptop is an MSI GF63 Thin 11SC)

@grimy400
Copy link
Author

Yes no problem ! I have the msi ge66 12ugs

@Sparronator9999 Sparronator9999 removed the status: needs triage This issue is awaiting a triage label Oct 27, 2024
@Sparronator9999 Sparronator9999 changed the title Full blast hokey ? Full blast hotkey ? Oct 27, 2024
@ios7jbpro
Copy link
Contributor

since this is in progress, not to be bothering or anything, is this going to also support changing the power profiles? e.g on most msi laptops where the f7 key changes it with a small popup message at the bottom showing the profile(when using msi center that is)

@Sparronator9999
Copy link
Owner

is this going to also support changing the power profiles?

You can set the performance mode to be applied per-profile as of v1.0.2. I will see if I can add a way to change the default performance mode (applied when not overridden by a fan profile).

on most msi laptops where the f7 key changes it with a small popup message at the bottom showing the profile(when using msi center that is)

On my laptop, the Fn+F7 key combo just opened MSI Center if I remember correctly (haven't had it installed since at least last year). I want to add support for this special key to Hotkey Handler, but I'm not sure if it works reliably on all MSI laptops (in fact, it's currently been removed from the current (pre-commit) source code until I find a way to reliably detect this key press).

You can test if it works properly on your laptop with the latest Hotkey Handler (you might need to compile it or scroll back a fair bit in GitHub Actions), it should open the Config Editor by default.

@ios7jbpro
Copy link
Contributor

ios7jbpro commented Feb 24, 2025

That is not what I was referring to.

Example image(taken from Google):

Image

When you're using MSI Center and use the Fn+F7 keybind, it would switch between those power profiles(at least for my Crosshair). This is already an option under extras on YAMDCC, I was just asking if it will be possible to use a keybind like this to switch between them quickly like how MSI Center does it.

You can test if it works properly on your laptop with the latest Hotkey Handler (you might need to compile it or scroll back a fair bit in GitHub Actions), it should open the Config Editor by default.

Seems to not work unfortunately.

However I do know that using that function key actually triggers one of the invisible F13 to F24(I'm sure you know about these keys, they actually do exist, just not in a regular keyboard, it's a google search away) keys to switch the profiles, which is what MSI Center binds it to. But again, thats how it is on my laptop. It's likely different for each on their own

@Sparronator9999
Copy link
Owner

Okay, time for a long one. Read if you dare. Skip to bottom for a keyboard test program to (hopefully) get the shortcut that the MSI Center key is pressing.

I was just asking if it will be possible to use a keybind like this to switch between them quickly like how MSI Center does it.

I think I already mentioned above (or rather, said I'd think about it), but I do plan to allow switching these performance modes via hotkey combination (although I'm not sure if I will be able to get the MSI Center key working reliably enough to implement your described behaviour).

Seems to not work unfortunately

I just committed an update which removed the MSI Center key function since it wasn't working for anyone but me, and I replaced (or rather, will replace) the global keyboard hook (see above documentation links) with calls to RegisterHotKey and UnregisterHotKey.

However I do know that using that function key actually triggers one of the invisible F13 to F24 [...] keys to switch the profiles, which is what MSI Center binds it to

Why, I do know about those keys (last I heard of them, the new "copilot" key on some of Microsoft's new laptops presses some convoluted shortcut that ends in F23).

However, when I use a small keyboard test app I wrote to test the MSI Center key (not currently publicly available), I get a virtual key code of 255, scan code of 10, and the "extended key" flag set after I press it at least twice, otherwise nothing happens (see documentation for LowLevelKeyboardProc and the struct that gets passed to it, KBDLLHOOKSTRUCT, for more info on these parameters). The webcam key is similar, but produces a scan code of 110. However this key already works as expected, so no work needed there :)

Interestingly enough, testing the touchpad disable button (F3 on my keyboard) produces the following shortcut: Ctrl+Win+F24, and same with F2 (which maps to Win+P, or the "Project" popup). None of the other keys exhibit this behaviour.

Anyways, I have attached the keyboard tester mentioned above here. If you don't mind, could you please test the MSI center key (and others, if you want) and report back on their behaviour? You can leave MSI Center running if you want, it might produce more interesting output.

@ios7jbpro
Copy link
Contributor

ios7jbpro commented Feb 24, 2025

Read if you dare.

Not even a challange:P

I just committed an update which removed the MSI Center key function since it wasn't working for anyone but me, and I replaced (or rather, will replace) the global keyboard hook (see above documentation links) with calls to RegisterHotKey and UnregisterHotKey.

So I basically wasted my entire morning today compiling the app and trying to use the built HotkeyHandler.exe LOL

Anyways, I have attached the keyboard tester mentioned above here. If you don't mind, could you please test the MSI center key (and others, if you want) and report back on their behaviour?

Of course, that is why I am here for, to help having a great alternative to MSI Center:D

Anyways, this is what I see when I press the Fn+F7(msi center key):

[00:08:20.302] Key pressed: LButton, OemClear (ScanCode = 17, ExtendedKey = True)

For the Webcam(F6):

[00:08:34.977] Key pressed: LButton, OemClear (ScanCode = 110, ExtendedKey = True)

For the microphone(F5):

[00:08:59.435] Key pressed: LButton, OemClear (ScanCode = 113, ExtendedKey = True)

For the keyboard backlight:

[00:09:19.427] Key pressed: LButton, OemClear (ScanCode = 14, ExtendedKey = True)

For the touchpad(F4), can confirm it works the same way:

[00:09:41.010] Key pressed: LControlKey (ScanCode = 29, ExtendedKey = False)
[00:09:41.031] Key pressed: LWin (ScanCode = 91, ExtendedKey = True)
[00:09:41.047] Key pressed: F24 (ScanCode = 118, ExtendedKey = False)

Full blast key(Fn+Up Arrow):

[00:10:12.488] Key pressed: LButton, OemClear (ScanCode = 61, ExtendedKey = True)

@porkmanager
Copy link
Contributor

I have attached the keyboard tester mentioned above here. If you don't mind, could you please test the MSI center key (and others, if you want) and report back on their behaviour?

Mine are the same as ios7jbpro has shown before.
I remember I was able to remap those combinations with the https://github.com/randyrants/sharpkeys utility when I needed to remap some keybindings. It shows different values. It probably would be useful in your keybinding workaround.
For example this code sharpkeys parse when I push fn+f7(msi key):

Image

That key can be remapped with sharpkey and it wroks.

@ios7jbpro
Copy link
Contributor

That key can be remapped with sharpkey and it wroks.

You can also use PowerToys for this, although it'll show "Unknown" key instead

@Sparronator9999
Copy link
Owner

Sparronator9999 commented Feb 25, 2025

Here's what my MSI Center key (same Fn+F7 combo) maps to:

Image

It seems like it uses a different key for every laptop...

@ios7jbpro, could you post what key bind appears when you use SharpKeys? Or is it the same as mine or @porkmanager's?

EDIT: I've just read your post using my keyboard tester. It looks like your MSI Center keybind is possibly different to both my laptop and @porkmanager's.

EDIT 2 (responding to the rest of @ios7jbpro's message):

So I basically wasted my entire morning today compiling the app and trying to use the built HotkeyHandler.exe LOL

Sorry... (I did say in the commit message that I removed the MSI Center key functionality...)

Of course, that is why I am here for, to help having a great alternative to MSI Center:D

I still can't believe how much of a following I've gained for this project (even if small compared to many much bigger projects).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants