Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The character щ (CYRILLIC SMALL LETTER SHCHA) looks wrong in italic under Bulgarian Cyrillic #532

Open
skanev opened this issue Feb 5, 2021 · 10 comments

Comments

@skanev
Copy link

skanev commented Feb 5, 2021

I noticed that the letter "щ" looks wrong under the Bulgarian cyrillic when in italic. The body of the letter looks like the lowercase "т" (english "m"), but it should be "flipped vertically".

Here's an example:

щ

It should look like the line above.

I'm using the Merriweather provided by Google Fonts. Here's a jsfiddle illustrating the problem: https://jsfiddle.net/ohs608L1/

@EbenSorkin
Copy link
Contributor

I will investigate this over the weekend and can hopefully find the reason for this. It might be that language support Open Type code needs to be updated. Thanks very much for your feedback.

@skanev
Copy link
Author

skanev commented Feb 6, 2021

Thanks! I noticed in general that Щ is problematic in Bulgarian Cyrillic - even in “roman” it looks like the International/Russian form, not the Bulgarian one.

@EbenSorkin
Copy link
Contributor

EbenSorkin commented Feb 6, 2021 via email

@skanev
Copy link
Author

skanev commented Feb 7, 2021

I'm sorry, I believe I mislead you about Щ in "roman" case.

My personal preference would have been for the upper case of Ц, Ш, Щ to follow the lowercase form (arcs instead of a a straight line in the bottom; it looks really jarring to me in "phrases" like "Щеш-нещеш" to have the capital Щ so different from the lowercase щ), but I erroneously thought that this was the standard form. It's not. Wikipedia's article includes a few samples (vs. "international", or as it calls it, "Russian" Cyrillic). From what I can tell, the best reference is this image, linked on the page (top half says "Traditional form of the Bulgarian Alphabet", bottom one says "Modern form of the Bulgarian alphabet"), and as far as I can tell, Merriweather follows it to the letter, apart from щ.

So please disregard my second reply, unless you wan't to follow the dubious personal preference of a non-professional :)


Going back to the "щ in italic" issue, I think it's just a problem with the italic version of the font.

I downloaded the Glyphs app, and looking at the glyph files, it seems the source is wrong. I also tried out the variable ttf in the master branch (as opposed the Google's hosted font), and it has the same issue:

Font_name_-_Web_Font_Specimen

Everything seems right, apart from lowercase "щ", which looks like it has its body flipped – it looks like an "m" while it should appear like "ш", but with a descender like "ц"

P.S.: I'd like to take an extra moment to thank you for Merriweather. It's an incredible font and I absolutely love it.

@StefanPeev
Copy link

It's very easy to correct the problem. You need to delete uni0449 from class locl and uni0449.loclBGR from class locl2 (in all Italics). Thus the default italic letter form uni0449 (small Cyrillic letter щ) will be used both for international Cyrillic and for Bulgarian Cyrillic as well. They do not differ in their appearance in the italic styles.

@EbenSorkin
Copy link
Contributor

EbenSorkin commented Aug 19, 2021 via email

@skanev
Copy link
Author

skanev commented May 18, 2022

Any chance of resolving this?

@doganov
Copy link

doganov commented Sep 2, 2023

I was just about to report the exact same issue, but found it already reported. I can confirm that the problem with the strangely flipped glyph for 0449 CYRILLIC SMALL LETTER SHCHA is only observed on the italic styles.

(I am using the Merriweather TTF files from this repo, not Google Fonts.)

@skanev
Copy link
Author

skanev commented Nov 29, 2023

I've tried checking out the repository and fixing this in order to open a pull request, but I failed. If somebody can provide some guidance on how to do it, I'm very happy to make a change and open a PR, as it should be a simple fix. Here's what I tried to do:

  • Download Glyphs 3 and open the file. Right out of the bat I got a warning that Merriweather-Italic was created with an old version of the program and it asked me to do some conversion. I tried making a change, but it doesn't want to save.
  • I tried to open the file and edit it in Vim, but I got lost at some point and couldn't figure out what to change exactly.
  • Finally, I downloaded Glyph 2 and it I managed to edit and remove the glyph. I got this diff which didn't seem perfectly right to me, as it has removed the glyph, but shcha-cy.loclBGR is referred to some other places in the document.

It was all moot, though, because when I tried to build it by following the README in order to test the change, there was no sources/build.sh file.

I'm unsure how to proceed.

@doganov
Copy link

doganov commented Nov 29, 2023

It seems like sources/build.sh was removed with commit d2fcfc5f00063d8972e1a1eb56af3d92e273e5f9. BTW, this is a huge tree change, git show --stat reporting:

...
477945 files changed, 62 insertions(+), 92006621 deletions(-)

But there is a clue in the commit message:

    - Use gftools builder

I have no idea whether this helps or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants