CLI-47 support multiple files & dir analysis with secrets#96
CLI-47 support multiple files & dir analysis with secrets#96sophio-japharidze-sonarsource wants to merge 1 commit intomasterfrom
Conversation
jonas-wielage-sonarsource
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick improvement here 💪
Please have a look at my comments to see if it's worth adding before merging
fad812c to
f7aee28
Compare
SonarQube reviewer guideSummary: Refactor Review Focus:
Start review at:
|
| .option('--stdin', 'Read from standard input instead of paths') | ||
| .action((paths: string[], options: AnalyzeSecretsOptions) => | ||
| runCommand(() => | ||
| analyzeSecrets({ paths: Array.isArray(paths) ? paths : [], stdin: options.stdin }), |
There was a problem hiding this comment.
As discussed we will need to think about coherent UX for all the analysis we will have. What happens if people call just parent command:
sonar analyze file1.txt file2.txt
What happens to analyzing commands who doesn't support multi-file analysis?
| 'sonar analyze secrets': [ | ||
| { | ||
| command: 'sonar analyze secrets --file src/config.ts', | ||
| command: 'sonar analyze secrets src/config.ts', |
There was a problem hiding this comment.
There's no example that shows we can call with many files.




No description provided.